CARDS-2808: Clarity Import may assign forms to the wrong visit if the same visit ID is used for a different patient - #2422
Draft
sdumitriu wants to merge 3 commits into
Draft
CARDS-2808: Clarity Import may assign forms to the wrong visit if the same visit ID is used for a different patient#2422sdumitriu wants to merge 3 commits into
sdumitriu wants to merge 3 commits into
Conversation
sdumitriu
force-pushed
the
CARDS-2808-subject-hierarchy
branch
from
July 28, 2026 13:31
7a37423 to
d3eb8a7
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
… same visit ID is used for a different patient
ConfiguredGenericMapper lets a mapping copy another column instead of
assigning a literal, by configuring the value as "%{COLUMN NAME}%". It
stripped the leading "%{" but only one of the two trailing characters, so
it looked the column "COLUMN NAME}" up, which never exists. The feature
could therefore never have worked: it always assigned null.
117 tests, covering every class that can be exercised without a Clarity database behind it.
sdumitriu
force-pushed
the
CARDS-2808-subject-hierarchy
branch
from
August 11, 2026 22:32
d3eb8a7 to
46d85cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.