Fix corner case for YAML parsing with primitive types#247
Merged
stephenamar-db merged 2 commits intomasterfrom Dec 31, 2024
Merged
Fix corner case for YAML parsing with primitive types#247stephenamar-db merged 2 commits intomasterfrom
stephenamar-db merged 2 commits intomasterfrom
Conversation
stephenamar-db
force-pushed
the
yamlfix
branch
from
5172e9e to
ca5ab6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at google/jsonnet#1109 and realized that we did not parse yaml correctly for primitive types:
std.parseYaml("0777")returned[511]instead of511(something that other implementations of jsonnet do)