Skip to content

Comments

Fix usage of - in stripChars with the introduction of RE2#253

Merged
stephenamar-db merged 1 commit intomasterfrom
fixstrip
Jan 3, 2025
Merged

Fix usage of - in stripChars with the introduction of RE2#253
stephenamar-db merged 1 commit intomasterfrom
fixstrip

Conversation

@stephenamar-db
Copy link
Collaborator

With this PR, I fix a regression introduced with the migration to RE2.

  • If there's a - in the chars in the *stripchars functions, we move it to the end
  • explicitely use RE2 with scala native (instead of the thin wrapper around it), which then allows us to
  • Enable stripchars test cases for jvm, js & native.

@stephenamar-db stephenamar-db marked this pull request as ready for review January 2, 2025 23:24
@stephenamar-db stephenamar-db merged commit 6aa8e1b into master Jan 3, 2025
6 checks passed
@stephenamar-db stephenamar-db deleted the fixstrip branch January 3, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants