Skip to content

ProfilingEvaluator: update ExprBox.name to print builtin function and operator names #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenamar-db merged 3 commits into from
Feb 6, 2025
Merged

ProfilingEvaluator: update ExprBox.name to print builtin function and operator names #264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d3698
ProfilingEvaluator
JoshRosen Jan 24, 2025
ba59642
Merge remote-tracking branch 'origin/master' into profile-nicer-output
JoshRosen Jan 27, 2025
785e581
Handle ApplyBuiltin3/4
JoshRosen Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion bench/src/main/scala/sjsonnet/ProfilingEvaluator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,20 @@ class ProfilingEvaluator(resolver: CachedResolver,
var totalTime: Long = 0
lazy val prettyOffset = prettyIndex(expr.pos).map { case (l,c) => s"$l:$c" }.getOrElse("?:?")
lazy val prettyPos = s"${expr.pos.currentFile.asInstanceOf[OsPath].p}:$prettyOffset"
lazy val name = expr.getClass.getName.split('.').last.split('$').last
lazy val name: String = {
val exprName = expr.getClass.getName.split('.').last.split('$').last
val funcOrOptName: Option[String] = expr match {
case a: Expr.ApplyBuiltin => Some(a.func.functionName)
case a: Expr.ApplyBuiltin1 => Some(a.func.functionName)
case a: Expr.ApplyBuiltin2 => Some(a.func.functionName)
case a: Expr.ApplyBuiltin3 => Some(a.func.functionName)
case a: Expr.ApplyBuiltin4 => Some(a.func.functionName)
case u: Expr.UnaryOp => Some(Expr.UnaryOp.name(u.op))
case b: Expr.BinaryOp => Some(Expr.BinaryOp.name(b.op))
case _ => None
}
exprName + funcOrOptName.map(n => s" ($n)").getOrElse("")
}
}

class OpBox(val op: Int, val name: String) extends Box
Expand Down
Loading