Merged
Conversation
RafalSierkiewicz
commented
Apr 2, 2025
Contributor
Author
|
Can we try to merge it together . I feel that we need some deeper domain knowledge here 🙏 |
Contributor
Author
|
@stephenamar-db any chances we can make this cross compile for Scala 3 ? |
Contributor
|
Thanks, I just found I need this, because one of my dependencies is using Scala 3.3.5:) |
He-Pin
reviewed
Apr 16, 2025
Collaborator
|
I will gladly review this |
Collaborator
|
I've branched the pre-scala3 version into the branch 0.4-series. master will be for the work to get it to run with scala3. Once it's stable, we'll say good bye to 0.4.x. |
RafalSierkiewicz
force-pushed
the
scala3
branch
from
fa13998 to
32c9904
Compare
| env: | ||
| # Set LANG=C to simulate least-common-denominator target deployment environments: | ||
| LANG: C | ||
| SCALANATIVE_THREAD_STACK_SIZE: 10m |
Contributor
Author
There was a problem hiding this comment.
note: to prevent stackoverflow in native tests scala-native/scala-native#4253
He-Pin
reviewed
Apr 19, 2025
He-Pin
reviewed
Apr 20, 2025
stephenamar-db
approved these changes
Apr 20, 2025
Collaborator
stephenamar-db
left a comment
stephenamar-db
left a comment
There was a problem hiding this comment.
Aside from the .toSeq bit, I don't see any major changes.
Contributor
|
Can't wait to have a fresh new release with this 😍 |
He-Pin
reviewed
Apr 21, 2025
He-Pin
reviewed
Apr 21, 2025
He-Pin
reviewed
Apr 21, 2025
He-Pin
reviewed
Apr 21, 2025
Co-authored-by: He-Pin(kerr) <hepin1989@gmail.com>
Co-authored-by: He-Pin(kerr) <hepin1989@gmail.com>
Co-authored-by: He-Pin(kerr) <hepin1989@gmail.com>
Co-authored-by: He-Pin(kerr) <hepin1989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to migrate code to scala 3. This required updates of some libs and a little code adjustments.
I would appreciate your input 🙏