chore(registry): load_catalog/load_signals dal registry fusion (registry.json) - #46
Merged
Merged
Conversation
…try.json) Sostituisce clean_catalog.json/pipeline_signals.json con registry.json: - load_catalog: legge registry.json (sezione datasets, struttura identica) - load_signals: legge registry.json e normalizza il blocco run → sample_run (status/checked_at/run_url derivati da run_id/started_at) per compat con le pagine - test: campionato su registry fusion, verifica normalizzazione sample_run
Il vecchio pipeline_signals.json esponeva il run come 'latest_run'; le pagine usavano 'sample_run' (campo inesistente → bug latente: i run non venivano mai mostrati). Con il registry, il blocco è 'run': normalizzazione loader + pagine allineate a 'run', fix del bug latente.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Migra i loader del dashboard dal legacy
clean_catalog.json/pipeline_signals.jsonal fusion registry (registry/registry.jsondi dataset-incubator).Contesto collegato
Migrazione registry (fusion ADR): DI produce
registry.jsonunico (sezioni datasets/marts/signals/codelists/entities); i vecchi artifact separati sono proiezioni legacy da rimuovere dopo la migrazione dei consumer. data-explorer già migrato (#226).Cosa cambia
sources.py:load_catalog()→ leggeregistry.json(sezionedatasets, struttura identica al vecchio clean_catalog)load_signals()→ leggeregistry.jsone normalizza il bloccoruninsample_run(statusSUCCESS→passed,checked_atdastarted_at,run_urldarun_id) — i consumer delle pagine non cambianotests/test_sources.py: campionati su registry fusion; verifica della normalizzazionesample_run; fallbackload_signals→{"signals": []}Verifica
pytest38 verdi,ruffpulitocatalog.get("datasets")/signals.get("signals"), presenti nel registryNote / rischi
load_catalogeload_signalsfanno ciascuno un fetch diregistry.json(il registry ha siadatasetschesignals) — leggermente ridondante ma innocuo (cachest.cache_dataper loader).run_urlderivati darun_idsono nuovi rispetto al vecchiosample_run(che aveva URL esplicita); il formatohttps://github.com/dataciviclab/dataset-incubator/actions/runs/{run_id}è coerente con i run ID del toolkit.