[DATAFLINT-4798] problem with codegen support on spark<3.2#66
Merged
Conversation
- Use non-paginated /sql endpoint for Spark < 3.2 apps where the paginated API returns 404 - Handle per-execution planGraph failures in DataflintSQLPlanPage instead of failing the entire batch (fixes NoSuchElementException for apps missing plan data in KVStore) - Fix catch block return type from JObject to JArray in both Spark 3 and Spark 4 SQLPlanPage - Guard against non-array sqlplan response in frontend Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…like there is a bug in spark<3.2 where even if supportCodegen method returns false then just since class inherits from codegen then it causes spark to be confused. so now only if original exec exterds Codegen it will get TimedWithCodegenExec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split TimedExec to 2 classes whether they have CodeGen or not. seems like there is a bug in spark<3.2 where even if supportCodegen method returns false then just since class inherits from codegen then it causes spark to be confused. so now only if original exec exterds Codegen it will get TimedWithCodegenExec