Skip to content

p2p/discover/topicindex: keep bucket IP tracker consistent on record update#92

Open
srene wants to merge 1 commit into
topdiscfrom
fix/registration-ip-tracker-update
Open

p2p/discover/topicindex: keep bucket IP tracker consistent on record update#92
srene wants to merge 1 commit into
topdiscfrom
fix/registration-ip-tracker-update

Conversation

@srene

@srene srene commented Jul 19, 2026

Copy link
Copy Markdown
Member

Closes #79

…update

When an already-known node presented a newer record with a different
endpoint, Registration.AddNodes adopted the new IP without updating the
bucket's IP-limit tracker. This leaked the old subnet's slot and let a
second address from the new subnet bypass the per-bucket cap. Maintain
the tracker on the update path and re-check the new endpoint.
@srene
srene marked this pull request as ready for review July 20, 2026 12:53
@srene
srene requested a review from fjl as a code owner July 20, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

p2p/discover/topicindex: registration AddNodes record-update path bypasses the per-bucket IP-diversity limit

1 participant