Fix/quickstart demo flow#75
Open
lakshay-nasa wants to merge 3 commits into
Open
Conversation
DataHub v1.5+ requires DATAHUB_TOKEN_SERVICE_SIGNING_KEY and DATAHUB_TOKEN_SERVICE_SALT to be non-empty. Without them the system-update container fails on a fresh install. Auto-generate both with openssl rand if not already set in the environment.
…ted config The agent defaults to reading config.yaml from ~/.datahub/analytics-agent/ which does not exist inside the container. Without ENGINES_CONFIG pointing at /app/config.yaml, the bootstrap seeds no engines and the agent starts with no data source connected.
….internal The native demo flow runs the agent directly on the host machine, so MySQL and DataHub GMS are reachable via localhost. Using host.docker.internal caused DNS resolution failures on some macOS setups and always fails on Linux where Docker Desktop is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bash quickstart.shcompletes without signing key erroranalytics-agent quickstart --democonnects to MySQL on all platforms