Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aimurphy
reviewed
Mar 13, 2026
This comment has been minimized.
This comment has been minimized.
aimurphy
reviewed
Mar 13, 2026
Co-authored-by: April I. Murphy <36110273+aimurphy@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
aimurphy
requested changes
Mar 13, 2026
Contributor
aimurphy
left a comment
There was a problem hiding this comment.
There are some things that still need to be addressed:
- Change the product name in the README.md
- There are several instances of
{company} {product}that need to be changed to just{product}. - There are several instances of
{product} {pulsar-short}that are now repetitive (Apache Pulsar Pulsar). Please search and address each one. - There is a mix of
{company} {pulsar-short} Helm chartand{product} Helm chart- this could be confusing and misconstrued as two different Helm charts. - Please manually add a reference to the old name to more topics. You can use the luna-name.adoc partials in an admonition, or manually add
(formerly {company} Luna Streaming).- pulsar-sql.adoc (add a note to the intro)
- pulsar-beam.adoc (add a note to the intro)
- connectors/pages/index.adoc (line 5)
- quickstart-helm-installs.adoc (line 8)
- quickstart-server-installs.adoc (line 3)
- supported-versions.adoc (add a note to the intro)
- upgrade-guide.adoc (line 4) (I think this topic is only in v 3.1_3.x)
- functions.adoc (line 7)
- scale-cluster.adoc (line 3)
- Ask Kim if the nav menu needs to change. If so, please open PRs against the datastax-docs-site and docs-ui repos.
Please repeat these changes on all 4 releases.
|
Build successful! ✅ |
aimurphy
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change naming of product in partial, index, and FAQ.