Cache file size rather than compute in StorageBuffer::read_segment()#92
Merged
nalinigans merged 1 commit intodevelopfrom Mar 19, 2021
Merged
Cache file size rather than compute in StorageBuffer::read_segment()#92nalinigans merged 1 commit intodevelopfrom
nalinigans merged 1 commit intodevelopfrom
Conversation
…). Also reduced the size of writes in test operations to finish in a decent time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache filesizes rather than re-compute in StorageBuffer::read_segment().
Removed some dead code in StorageBuffer, we could make another pass at optimization here, but leaving it as is for now. Also, we are seeing some SIGPIPE curl issues only on
Centoswith parallel downloads/uploads on Azure Blob Storage, there is an issue open in the azure lite sdk. Some suggestion to a solution in this PR. Will look into implementing a signal handler as suggested here.Also, as part of this PR, reduced the size of writes in test cloud filesystem operations to finish in a decent time to help with GitHub builds.