Repository navigation
Feature/exceptions+error handling - #38
Merged
Merged
Conversation
…' into feature/Exceptions+errorHandling # Conflicts: # server/api/Services/TransactionService.cs # server/api/Services/UserService.cs
alexapostol89
approved these changes
Dec 18, 2025
jianmingf
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Exception & Test Refactor
This PR standardizes error handling and service test behavior across the entire API.
API changes
Introduced a centralized API exception model using ApiException and ApiErrors
Services now throw semantic, HTTP-aware exceptions (400, 401, 404, 409) instead of generic .NET exceptions
Removed scattered try/catch blocks from services and rely on global exception middleware
Aligned service method contracts with clear API semantics
Test updates
Updated all service tests to assert ApiException instead of framework exceptions
Added explicit assertions for HTTP status codes where applicable
Renamed tests to reflect API behavior rather than implementation details
Ensured constructor usage matches current service dependencies
Why
Keeps controllers thin and services expressive
Ensures consistent, predictable error responses for clients
Improves test reliability and future-proofing
Makes error handling easier to reason about and extend
No functional behavior changes were introduced beyond error semantics and naming consistency.