Added Support for Enchanted - Witchcraft - #5
Closed
ArtpokeBr wants to merge 2 commits into
Closed
Conversation
Update mods.conf to include enchanted-witchcraft
| smartbrainlib 661293 6668303 # 2025-06-18T21:21:13.86Z | SmartBrainLib-neoforge-1.21.1-1.16.8.jar | ||
| kotlin-for-forge 351264 6497906 # 2025-05-05T07:11:02.707Z | kotlinforforge-5.8.0-all.jar | ||
| roots 246183 6664961 # 2025-06-18T06:52:53.79Z | roots-4.0.0.7-alpha.jar | ||
| enchanted-witchcraft 560363 6668864 |
Owner
There was a problem hiding this comment.
6668864 is the latest file for Fabric.
6668863 is the Neoforge version, which we need here.
And murphy obviously had to hit you with one of the corner cases. Enchanted Witchcraft has extra dependencies on Modopedia and StateObserver. All in all the PR has to look like this:
enchanted-witchcraft 560363 6668863
modopedia 1132038 6673794
stateobserver 701213 6522771
Owner
|
I've applied these changes and also added Malum (and its dependencies). You can find the packs in the generated folder or in this zip: for-artpoke.zip The next version of Bonsai Trees will include these by default. |
Contributor
Author
|
Nice! sorry for the inconvenience btw Dave, it seems that I was not very lucky with this ''-.- |
Owner
|
Not an inconvenience at all. Quite the opposite. Good test that shows the system needs some more refinement :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this is right, I tried to follow the guide :)