Skip to content

feat(example): Added example with esp console integration with ssh. - #2

Merged
david-cermak merged 1 commit into
david-cermak:mainfrom
abhik-roy85:console_component_integration
Aug 13, 2025
Merged

feat(example): Added example with esp console integration with ssh.#2
david-cermak merged 1 commit into
david-cermak:mainfrom
abhik-roy85:console_component_integration

Conversation

@abhik-roy85

Copy link
Copy Markdown
Contributor

No description provided.

@david-cermak david-cermak left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting the new example!

ESP_ERROR_CHECK(console_cmd_start());
#endif

while (true) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs a bit of cleanup :-)

// Runs the console REPL task for command processing.
static void console_task(void* arg)
{
#if 1

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if 1

also cleanup

@david-cermak
david-cermak merged commit 7d395ae into david-cermak:main Aug 13, 2025
4 checks passed
@abhik-roy85
abhik-roy85 deleted the console_component_integration branch August 25, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants