Support reading and writing surface normals #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #34 and #26.
Reading normals just required adding the fields to
SUPPORTED_POINT_FIELDS(I went with float32, which matches libe57). I also replaced the file I was using to test reading unsupported point fields, now that normals are supported.Writing normals required very similar code to adding color in
write_scan_raw. However, it also requires adding the prefix 'nor'. I did a bit of digging, and theStructureNodeImpl::setchecks the element name, including checking if the prefix is valid (text before the colon), i.e. added to a list of supported prefixes. The prefix can be added withImageFileImpl::extensionsAdd, which was already included in the wrapper.