Fix Ruby 3.2/3.3 compatibility in Fixnum test#142
Merged
davidcelis merged 1 commit intodavidcelis:masterfrom Nov 10, 2025
Merged
Fix Ruby 3.2/3.3 compatibility in Fixnum test#142davidcelis merged 1 commit intodavidcelis:masterfrom
davidcelis merged 1 commit intodavidcelis:masterfrom
Conversation
Replace Fixnum with Integer in spec/rails_spec.rb to fix test failures on Ruby 3.2 and 3.3. Background: - Fixnum and Bignum were unified into Integer in Ruby 2.4 - The test was monkey-patching Fixnum, which behaves differently in Ruby 3.2+ - This caused the "default per page in model" test to fail for Kaminari and WillPaginate on Ruby 3.2/3.3 Changes: - Replace all instances of `class Fixnum` with `class Integer` - Add comment explaining the Ruby 2.4+ change - All tests now pass on Ruby 3.1, 3.2, and 3.3 Testing: - Ruby 3.2.7: All Kaminari and WillPaginate tests pass - Ruby 3.3.8: All Kaminari and WillPaginate tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Fixnum with Integer in spec/rails_spec.rb to fix test failures on Ruby 3.2 and 3.3.
Background:
Changes:
class Fixnumwithclass Integer