Merged
Conversation
Pagy.options has been deprecated in version 43.3.0. ddnexus/pagy@88d52de#diff-05ff71ebdb99c42d63eefbef934c5197fc72f8f03b8dbbe363ca53e5615f0429R26 The current state causes the following warning: [PAGY] 'Pagy.options' is deprecated: use 'Pagy::OPTIONS directly' The new Pagy::OPTIONS has actually been introduced in version 43.2.10 but only announced in version 43.3.0. We need to bump the minimal supported version because 43.0 does not support it. ddnexus/pagy@4a70be0 Since version compatibility is checked through the gem specification, I suggest we remove it from the README. Specifying pagy without version already installs the latest one, and explicit version constraints in users’ Gemfile get outdated and become a hassle then.
Owner
|
@fmang Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pagy.options has been deprecated in version 43.3.0. See ddnexus/pagy@88d52de#diff-05ff71ebdb99c42d63eefbef934c5197fc72f8f03b8dbbe363ca53e5615f0429R26
The current state causes the following warning:
The new Pagy::OPTIONS has actually been introduced in version 43.2.10 but only announced in version 43.3.0. We need to bump the minimal supported version because 43.0 does not support it. ddnexus/pagy@4a70be0
Since version compatibility is checked through the gem specification, I suggest we remove it from the README. Specifying pagy without version already installs the latest one, and explicit version constraints in users’ Gemfile get outdated and become a hassle then.