🐛 Fixed: Introduce simulated failures for EmailBatchesImporter#39
🐛 Fixed: Introduce simulated failures for EmailBatchesImporter#39davidehuey wants to merge 1 commit into
Conversation
ref https://ghost.org/ In order to simulate real-world scenarios more accurately, this commit replaces the static 'submitted' status with a probabilistic check that marks 5% of the email batches as 'failed' instead of 'submitted'. This behavior better reflects production cases. Co-authored-by: davidehuey <9439876+davidehuey@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| const TableImporter = require('./table-importer'); | ||
| const {faker} = require('@faker-js/faker'); | ||
| const dateToDatabaseString = require('../utils/database-date'); | ||
| const {luck} = require('../utils/random'); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49acb3a57e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| email_id: this.model.id, | ||
| provider_id: `${new Date().toISOString().split('.')[0].replace(/[^0-9]/g, '')}.${faker.datatype.hexadecimal({length: 16, prefix: '', case: 'lower'})}@m.example.com`, | ||
| status: 'submitted', // TODO: introduce failures | ||
| status: luck(5) ? 'failed' : 'submitted', |
There was a problem hiding this comment.
When this random branch marks a seeded batch as failed, the parent row from emails-importer still always has emails.status = 'submitted'. In the real send path, any failed batch makes sendBatches() throw and the parent email is saved as failed, and the debug/retry UI keys important failure messaging off post.email.status === 'failed'; seeded data can therefore contain failed batches that don't exercise the parent-email failure flow and show as successfully sent emails.
Useful? React with 👍 / 👎.
1 participant
In order to simulate real-world scenarios more accurately, this commit replaces the static 'submitted' status with a probabilistic check that marks 5% of the email batches as 'failed' instead of 'submitted'. This behavior better reflects production cases.
PR created automatically by Jules for task 11878623067768453521 started by @davidehuey