Skip to content

server restart _timerAwaitable fix #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tothalexlaszlo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

server restart _timerAwaitable fix #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff1797
server restart _timerAwaitable fix
Mar 26, 2022
31d44e0
Merge branch 'main' into ServerRestart
tothalexlaszlo Jun 15, 2022
ab5162c
in case someone doublestop server
Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Bedrock.Framework/Server/Server.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ public class Server
private readonly ILogger<Server> _logger;
private readonly List<RunningListener> _listeners = new List<RunningListener>();
private readonly TaskCompletionSource<object> _shutdownTcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);
private readonly TimerAwaitable _timerAwaitable;
private TimerAwaitable _timerAwaitable;
private Task _timerTask = Task.CompletedTask;

internal Server(ServerBuilder builder)
{
_logger = builder.ApplicationServices.GetLoggerFactory().CreateLogger<Server>();
_builder = builder;
_timerAwaitable = new TimerAwaitable(_builder.HeartBeatInterval, _builder.HeartBeatInterval);
}

public IEnumerable<EndPoint> EndPoints
Expand All @@ -38,6 +37,8 @@ public IEnumerable<EndPoint> EndPoints

public async Task StartAsync(CancellationToken cancellationToken = default)
{
_timerAwaitable = new TimerAwaitable(_builder.HeartBeatInterval, _builder.HeartBeatInterval);

try
{
foreach (var binding in _builder.Bindings)
Expand Down Expand Up @@ -111,6 +112,8 @@ public async Task StopAsync(CancellationToken cancellationToken = default)
_timerAwaitable.Stop();

await _timerTask.ConfigureAwait(false);

_timerAwaitable = null;
}
}

Expand Down