Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the mget response schema with the intended field naming by returning doc_id (instead of id) for each document in MgetResponse, and updates the OpenAPI spec accordingly.
Changes:
- Update
MgetDocserialization to emitdoc_id(removeserde(rename = "id")). - Update
openapi.yamlMgetDocschema to usedoc_idand require it. - Add a unit test to lock in the
doc_idJSON field name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| searchlite-core/src/api/types.rs | Removes id serde rename for MgetDoc and adds a unit test asserting JSON uses doc_id. |
| openapi.yaml | Updates the MgetDoc schema property/required field from id to doc_id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_after(feat: mget &search_after#95)