Migrate tokenizer to langchain_tiktoken package#285
Merged
Conversation
orenagiv
changed the title
Owner
|
Thanks for your work @orenagiv! The package looks great. I've just finished the migration of the rest of the packages and fixing some tests. Do you think we can merge it already? |
davidmigloz
self-requested a review
January 9, 2024 20:53
Contributor
Author
|
Thanks @davidmigloz 🙏 Yep 🙂 fine by me! |
orenagiv
marked this pull request as ready for review
January 10, 2024 06:16
davidmigloz
added
t:enhancement
davidmigloz
approved these changes
Jan 10, 2024
davidmigloz
changed the title
Owner
|
merged! Thanks again 🚀 |
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Apr 22, 2024
…z#285) Switched from the tiktoken package to langchain_tiktoken in order to resolve the extremely long build-time release-mode issue. Original issue: mvitlov/tiktoken#5 The package owner didn't merge the pull request: mvitlov/tiktoken#6 So we're using the forked and refactored langchain_tiktoken package instead: https://pub.dev/packages/langchain_tiktoken --------- Co-authored-by: David Miguel <me@davidmiguel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched from the tiktoken package to langchain_tiktoken in order to resolve the extremely long build-time release-mode issue.
Original issue:
mvitlov/tiktoken#5
The package owner didn't merge the pull request:
mvitlov/tiktoken#6
So we're using the forked and refactored langchain_tiktoken package instead:
https://pub.dev/packages/langchain_tiktoken