Repository navigation
Conversation
…l line selection.
Since C-Kermit 5A(190) of 4 October 1994, wrtch(unsigned short) wrote a space character to the terminal buffer whenever a character with the invisible attribute was written. DECRQCRA demonstrates that a real VT420/500 doesn't work this way - instead it deals with it at render time. This commit adjusts K95 to do the same. Other things that read from the terminal buffer (mark-mode, etc) are still to be dealt with.
Copy-to-clipboard, Copy-to-Host, and Copy-to-Printer will now copy invisible text as the space character. And mark mode itself will treat invisible characters the same as it treats space, producing the same selection behaviour as in past releases of K95.
Visual C++ doesn't like comparing int with void*. Fair enough.
Invisible characters were previously stored as a space which is ineligible for inclusion in a URL. To retain the same behaviour as before, anything checking IsURLChar also now checks that the char isn't invisible. And for some reason quite a lot of stuff was calling IsURLChar, almost always directly before calling IsCellPartOfURL so that check has been moved *into* IsCellPartOfURL to tidy things up a little.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change stores invisible characters rather than converting them to space as has been done since C-Kermit 5A(190) of 4 October 1994 so that DECRQCRA can report the correct value for characters with that attribute set.
This change requires further changes elsewhere to deal with invisible characters now being stored:
\Fscrnstrshould return spaces for invisible characters