comments#1
Open
ayal wants to merge 1 commit into
Open
Conversation
davidvaks
reviewed
Mar 3, 2022
davidvaks
reviewed
Mar 3, 2022
davidvaks
reviewed
Mar 3, 2022
Comment on lines
+48
to
+51
| // i'm not sure path is encouraged or standard, and even if it was, it's too fragile | ||
| // what if you changed the html? this would break. maybe use "Element.closest" ? | ||
| const row = event.path[2]; | ||
| const taskTextCell = row.cells[1]; | ||
| const taskTextCell = row.cells[1]; // this is fragile too |
Owner
There was a problem hiding this comment.
yes, this is one of the places I really didn't like.
tried doing
event.target.parentNode() like in the MDN but got an exception for parentNode not being a function...
Collaborator
Author
There was a problem hiding this comment.
so yeah closest should work.
davidvaks
reviewed
Mar 3, 2022
davidvaks
reviewed
Mar 3, 2022
davidvaks
reviewed
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.