Skip to content

Make SOPS repair test names identify the key and scalar type #280

Description

@davidvornholt

Failures in the new SOPS scalar regression matrix are harder to diagnose because the parameterized test title labels the required key as though it were the ciphertext type. Leaving this alone adds avoidable investigation time whenever one of these security-contract tests fails.

Evidence

REQUIRED_TYPE_CASES supplies [key, path, type], but the format string begins with type:%s. A verbose run therefore prints names such as rejects complete type:ntfy_topic_url envelope ... when its type is bool.

Failure scenario

A future change breaks one scalar case. CI points the maintainer at a supposed ntfy_topic_url SOPS type before naming the real bool type later in the sentence, making the failing dimension unclear at first read.

Suggested verification

Rename the first placeholder as the key, then run bun test --verbose packages/standards-cli/src/structure-sops-repair.test.ts and confirm every case names both the key and scalar type accurately.

Found during the repair-verification pass for #278.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferred-findingDeferred review finding filed by a review-fix cycle

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions