Skip to content

Reuse an open standards sync pull request across scheduled runs #283

Description

@davidvornholt

Consumers accumulate duplicate standards-sync pull requests and abandoned automation branches whenever an update remains open for a week or pull-request creation fails after the branch push. This adds review noise and makes it unclear which update is authoritative, but it predates PR #282 and is not required to restore workflow-file synchronization safely.

Evidence

The scheduled workflow creates a timestamped branch for every changed run and calls gh pr create. It never looks up an existing standards-sync pull request and cannot reuse an orphaned branch.

  • .github/workflows/standards-sync.yml: branch names include the current timestamp.
  • .github/workflows/standards-sync.yml: the mutation path contains no gh pr list or gh pr view lookup.

Concrete failure scenario

A standards update opens a pull request on Monday and remains under review. The next Monday, the consumer default branch is still behind, so the same mirror diff is committed to a new timestamped branch and a second pull request opens. If gh pr create fails after push, the branch is left behind and the following run creates another one instead of recovering it.

Suggested verification

Use a stable automation branch or a durable pull-request marker, then simulate two consecutive changed runs against the same base. The second run should update the existing branch and pull request rather than create another pair.

Found during the bounded review-fix cycle for #282.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferred-findingDeferred review finding filed by a review-fix cycle

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions