Skip to content

Document where test secrets come from in CLAUDE.md - #85

Merged
davidwkeith merged 1 commit into
mainfrom
claude/affectionate-curie-3ekeg3
Oct 23, 2026
Merged

davidwkeith merged 1 commit into
mainfrom
claude/affectionate-curie-3ekeg3

Conversation

@davidwkeith

Copy link
Copy Markdown
Owner

Adds a Testing bullet to CLAUDE.md. Test secrets are fixed values in vitest.config.ts's miniflare.bindings (TOKEN_SIGNING_KEY, INTROSPECTION_TOKEN), and they take precedence over a local .dev.vars. Tests that need keypairs (test/syndication.test.ts) generate them. No secret file is needed locally or in CI, so there's no test .dev.vars.example.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CMCuDa11Qr39yxAQJNUXoH

Copy link
Copy Markdown
Owner Author

Code review: LGTM. The one-line docs change is accurate. I checked it against vitest.config.ts:13 (TOKEN_SIGNING_KEY and INTROSPECTION_TOKEN are set in miniflare.bindings) and test/syndication.test.ts (it generates its own keypair and passes {...env, ...}). It also sits well beside the other Testing bullets. I found no issues. I didn't verify the "win over a local .dev.vars" precedence claim by running the tests. This is a docs-only change, so I haven't merged it.


Generated by Claude Code

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://claude-affectionate-curie-3ekeg3-dwk.8k9dgysp29.workers.dev (commit 467d993)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://5998e564-dwk.8k9dgysp29.workers.dev 467d993 2026-10-23T03:29:18.308Z Visit the dashboard ↗

@davidwkeith
davidwkeith merged commit 90a98d3 into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants