type error fixes + cleanup#218
Open
bmdavis419 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
+68
to
+73
| - key: check | ||
| use: install-mintlify | ||
| run: bun run check:all | ||
| env: | ||
| PUBLIC_CONVEX_URL: https://example.com | ||
| PUBLIC_CLERK_PUBLISHABLE_KEY: abc123 |
Contributor
There was a problem hiding this comment.
The PR workflow ends with the check (type-check) step and never calls the test task. By contrast, .rwx/ci.yml does run tests on the main branch. This means broken tests can be merged through a PR without being caught until after they land on main.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .rwx/pr.yml
Line: 68-73
Comment:
**Tests not run on PRs**
The PR workflow ends with the `check` (type-check) step and never calls the `test` task. By contrast, `.rwx/ci.yml` does run tests on the main branch. This means broken tests can be merged through a PR without being caught until after they land on `main`.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Greptile Summary
This PR adds a new RWX-based CI/CD pipeline (
.rwx/+.captain/), wires up alint:allscript through Turbo, and fixes a TypeScript error insnapshot.tsby replacingimport.meta.mainwith a manual URL comparison. The infrastructure changes are additive and don't touch existing runtime behavior, but there are a few things to address:.rwx/pr.ymlruns lint and type-check but never the test suite. Broken tests will only surface after merging tomain.--frozen-lockfileis commented out in.rwx/ci.yml, making dependency installs non-reproducible until the TODO is resolved.snapshot.tsdeviates from Bun-first style — swappingimport.meta.mainfor aprocess.argv[1]URL comparison works in practice but goes against AGENTS.md, and is fragile with special-character paths. Fixing thetsconfigto includebun-typesis likely the cleaner solution..mdfiles were found in the repository.Confidence Score: 3/5
pr.ymland the disabled lockfile check, both of which are process/CI issues rather than runtime regressions..rwx/pr.yml(missing test step) and.rwx/ci.yml(disabled--frozen-lockfile)Important Files Changed
import.meta.mainwith a manualprocess.argv[1]URL comparison; functional in common cases but fragile with special-character paths and deviates from the project's Bun-first style guide.--frozen-lockfileis disabled with a TODO, making dependency installs non-reproducible until resolved.lint:allscript wired toturbo lint— clean, additive change.linttask withdependsOn: ["^lint"]to match the newlint:allscript — no issues.Prompt To Fix All With AI
Last reviewed commit: "rwx added in"
Context used: