Fix btca ask failures for streamed auth errors and chipwhisperer sparse checkouts#219
Open
da-beda wants to merge 1 commit into
Open
Fix btca ask failures for streamed auth errors and chipwhisperer sparse checkouts#219da-beda wants to merge 1 commit into
da-beda wants to merge 1 commit into
Conversation
|
@knauerp is attempting to deploy a commit to the davis7dotsh Team on Vercel. A member of the Team first needs to authorize it. |
e769483 to
977df1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BtcaErrormessages inbtca askinstead of surfacingEffect.tryPromisesearchPaths via--skip-checksValidation
bun test apps/cli/src/commands/ask.test.tsbun test apps/server/src/resources/impls/git.test.tsbun run check:clibun run check:serverCloses #211
Greptile Summary
This PR fixes two independent bugs: streamed
BtcaErrormessages being swallowed byEffect.tryPromisein theaskcommand, andgit sparse-checkout setfailing for submodule-backed search paths in chipwhisperer-style repos.ask.ts: Converts the bareEffect.tryPromise(async () => {...})call to the{ try, catch }overload. Thecatchhandler preservesBtcaErrorinstances thrown byonError(e.g.ProviderNotAuthenticatedError) rather than letting Effect wrap them in a generic "An error occurred in Effect.tryPromise" message. No existing behavior is changed for non-BtcaErrorthrows.git.ts: Extracts the duplicatedsparse-checkout set+checkoutsequence into an exportedsyncSparseCheckoutPathshelper and adds--skip-checksto thesparse-checkout setcall. The flag is necessary because git rejects paths that resolve to submodule gitlinks without it. The downstreamensureSearchPathsExistcheck remains in place to catch genuinely missing paths.Confidence Score: 5/5
Effect.tryPromisechange only adds acatchhandler that passesBtcaErrorthrough unchanged and wraps everything else the same way as before. The--skip-checkschange is guarded by the existingensureSearchPathsExistcheck so truly invalid paths are still rejected. No regressions identified.Important Files Changed
Effect.tryPromiseto include acatchhandler that preservesBtcaErrorinstances from streamed error events instead of letting Effect wrap them in a generic error message. Clean and targeted fix.syncSparseCheckoutPathsfunction and added--skip-checksflag to support submodule-backed search paths. The existingensureSearchPathsExistvalidation still guards against truly missing paths.BtcaErrorauth messages surface correctly to the user and do not leak theEffect.tryPromisewrapper message.syncSparseCheckoutPathsworks on both the initial clone and a subsequent update — exactly the scenario--skip-checkswas needed for.Reviews (2): Last reviewed commit: "Fix btca ask errors for streamed auth fa..." | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!