fix GitHub /blob/ URL extraction (#4)#5
Merged
Conversation
`?raw=true` on /blob/ URLs now returns 422; rewrite to raw.githubusercontent.com instead. Also fall back to HTML-page-derived metadata when the extracted markdown body has no upstream frontmatter, so blob URLs with -m get both frontmatter and body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?raw=trueongithub.com/.../blob/...URLs now returns 422 (empty HTML), sor11y -magainst a blob URL produced frontmatter-only output. Rewrite/blob/URLs toraw.githubusercontent.cominstead — same transform GitHub's own "Raw" button uses, and the path the issue reporter's workaround already proved works.extract-content-from-urlnow falls back to HTML-page-derived metadata when the extracted body has no upstream YAML frontmatter of its own. Result: blob URLs with-mget both frontmatter and body, matching prior expectations.Fixes #4.
Test plan
clojure -X:test— 100 tests, 262 assertions, 0 failurestest-github-url-normalizationfor the new target URL shapetest-github-blob-url-extractionexercises the blob → raw + HTML metadata composition offline via injectedfetch-fnr11y -m https://github.com/dazld/r11y/blob/main/README.mdreturns full README body (9225 chars) with frontmatter, vs. 12 lines / frontmatter-only before