[WIP] Refactor viz.py to attempt to improve code quality and better display AIS tracks#72
Draft
elliott-ruebush wants to merge 17 commits into
Draft
[WIP] Refactor viz.py to attempt to improve code quality and better display AIS tracks#72elliott-ruebush wants to merge 17 commits into
elliott-ruebush wants to merge 17 commits into
Conversation
4 tasks
elliott-ruebush
changed the title
elliott-ruebush
changed the title
elliott-ruebush
changed the title
elliott-ruebush
force-pushed
the
feature/ground_truthing_ais
branch
from
93f8c07 to
a09b4ab
Compare
elliott-ruebush
force-pushed
the
feature/vis_improvements_for_ais
branch
4 times, most recently
from
07b40ce to
431404e
Compare
Move track loading to utils for ground truthing and viz; add --track-source CLI with source-specific z handling. Not finalized — needs review and on-network smoke tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace deprecated -v/--vessels with --track-source (GPS/ADSB/AIS), route viz through load_tracks with include_faa_paths=False, keep ADSB on the NVSPL clock (no site timezone shift), and add loader tests plus docs. Co-authored-by: Cursor <cursoragent@cursor.com>
elliott-ruebush
force-pushed
the
feature/vis_improvements_for_ais
branch
from
431404e to
d963e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nps_active_space/viz/package from the monolithicscripts/viz.py(CLI shim remains atscripts/viz.py).DemElevationSampler, flat sea-surface fast path, and merged annotation meshes for PyVista performance.--vesselsto preview raw MXAK AIS tracks; improve CLI validation and logging.load_layered_activespaceand clearer errors when active-space layers are missing.Builds off #68 (
feature/ground_truthing_ais)Manual Testing
pytest(116 passed locally)python -m nps_active_space.scripts.viz GLBALSTL2024 -e <env> -awith AIS annotations are properly displayed (both the audible/inaudible boundaries on the polylines and the polylines themselves--vesselsfor raw AIS vessel tracks instead of annotations--active-spaceon a deployment with layered GeoJSON output