Declare runtime deps in pyproject.toml for all platforms#87
Open
elliott-ruebush wants to merge 5 commits into
Open
Declare runtime deps in pyproject.toml for all platforms#87elliott-ruebush wants to merge 5 commits into
elliott-ruebush wants to merge 5 commits into
Conversation
arpitjain099
approved these changes
Jul 7, 2026
arpitjain099
left a comment
arpitjain099
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Checked that the deps dropped from requirements.txt (beautifulsoup4, requests, contextily, pyogrio, etc.) aren't directly imported in the main codebase, so the trimmed dependency list is correct. The sys_platform markers for psycopg2 are a nice touch. CI simplification to a single pip install is much cleaner.
Move package discovery to setuptools packages.find, add [dev] extra with pytest, and make pyproject.toml the single install source on Windows, Linux, and macOS. CI installs via pip install -e ".[dev]" after matching system GDAL. Remove requirements.txt and document pip install from GitHub. Co-authored-by: Cursor <cursoragent@cursor.com>
elliott-ruebush
force-pushed
the
feature/pyproject-deps-ci
branch
from
0de84c5 to
87f1411
Compare
…in nps_active_space/
elliott-ruebush
commented
Jul 10, 2026
| name = "NPS-ActiveSpace" | ||
| version = "2.0" | ||
| description = "An NPS Sound Active Space Project." | ||
| version = "3.0" |
Collaborator
Author
There was a problem hiding this comment.
I bumped this version to 3.0 since we had mentioned it was inadvertently left out of date
elliott-ruebush
commented
Jul 10, 2026
Collaborator
Author
There was a problem hiding this comment.
unneeded file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Overview
pyproject.tomlthe single install source on all platforms, with the goal being to enable folks from various different platforms to more quickly get started with development on the repo.pip install GDAL==$(gdal-config --version)thenpip install -e ".[dev]"requirements.txtin favor ofpyproject.tomldependencies and update README with updated setup instructions for both direct pip installs from GitHub and editable installs of the cloned repoSome General Notes
psycopg2on Windows,psycopg2-binaryelsewhere.pandaspinned to<3for the moment just to avoid any unexpected issues from bumping pandas versions.pyproject.tomlmust be updated when bumping Python (currently cp312 win_amd64).Test plan
pip install -e ".[dev]"succeeds locallypytest tests/passes locally (80 tests) after installing in a fresh venv (and smoketesting -h for a script or two also works)pip install -e ".[dev]"+ pytest and run a script from a fresh clone on a Windows host