Add tests for computation.py pure-logic functions#95
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Tests for contiguous_regions (8 cases covering single/multiple blocks, all-true/all-false, alternating, numeric conditions), coords_to_utm (5 cases including Alaska, NYC, southern hemisphere, zone boundaries), and barometric_pressure (3 cases against known physical values). These are the highest-ROI test targets: pure numpy/math with no external dependencies, used throughout the pipeline. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for three functions in computation.py that had zero tests and no external dependencies (pure numpy/math).
contiguous_regions (8 test cases) - finds contiguous True regions in a boolean array. Tested with single block, multiple blocks, all true, all false, single element, alternating pattern, and numeric condition input.
coords_to_utm (5 test cases) - converts lat/lon to UTM EPSG codes. Tested with Denali Alaska (zone 5), New York (zone 18), southern hemisphere Sydney (zone 56), near the prime meridian, and a zone boundary.
barometric_pressure (3 test cases) - implements the barometric formula for atmospheric pressure at altitude. Verified sea level returns 101.325 kPa, pressure decreases monotonically with altitude, and 1500m falls in the expected 80-90 kPa range.
These are high-ROI test targets since contiguous_regions is imported by both metrics.py and models.py, and coords_to_utm is used throughout the pipeline for CRS handling.