Add type annotations to computation.py#98
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Annotate all 11 unannotated or partially-annotated functions with parameter and return types. Modernize existing typing imports to use native Python 3.12+ syntax (tuple instead of Tuple, X | None instead of Optional[X]) via `from __future__ import annotations`. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds type annotations to all 11 functions in
computation.pythat were missingparameter types, return types, or both. Also modernizes existing type imports
to use native Python 3.12+ syntax via
from __future__ import annotations.Changes:
expected_Lp,round_points,project_raster,ambience_from_nvspl,select_optimal, andnormalize_point_densitycontiguous_regions,audibility_to_interval,calculate_duration_summary,barometric_pressure,and
atmospheric_absorptionOptional[int]withint | None,Tuple[...]withtuple[...]in
build_src_point_mesh,create_overlapping_mesh, andcompute_fbetaList,Optional,Tuplefrom the typing importThis follows the same pattern as #91 for
layered_active_space.py. No runtimebehavior changes, only annotations.