Merged
Conversation
c096c8d to
a3dff54
Compare
…len', to avoid hiding the function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on VUnit#481 and it should be merged later.
This PR is work-in-progress towards VUnit#476 and VUnit#470.
vunit/vhdl/data_types/srcis modified:end function;andend procedure;are replaced withend;for coherency.Aliases are added to
integer_vector_ptrandstring_ptrin order to highlight the similarities between these files. Compare, e.g.,integer_vector_ptr_pkg-body-200x.vhdandstring_ptr_pkg-body-200x.vhdbefore and after this PR:The definition of types
integer_vector_t,integer_vector_access_t,string_ptr_access_t, etc. are moved to separate packages in a new subdir (vunit/vhdl/data_types/src/types). This is because, in the future, packages to support external models will depend on these types, andinteger_vector_ptr_pkg/string_ptr_pkgwill depend on the external models (or their placeholders).In the VHDL 2008 sources, there is no need to use custom types for the pointers. 'natural' is used instead.
When external models are added, the variable inside the pointer types will not be an explicit index. I think that
refis a better name.GHDL drops a lot of warnings because declaring parameter
lengthhides the function name. Options are renamed tolento avoid it.Parameter
indexused ingetandsetis declared as of typeinteger. However, it should benatural, because it is not possible to access to negative indexes.