Open
Conversation
Turns out it was am AppleDouble encoded Macintosh file
Added an invalid byte to a test header file, tests with unused_class would fail if fix_encoding is not called.
Signed-off-by: James Stout <stoutyhk@gmail.com>
Here's an example of a CHANGELOG.md entry: * [#39](https://github.com/dblock/fui/pull/39): Handle invalid byte sequences - [@jamesstout](https://github.com/jamesstout).Generated by 🚫 Danger |
Owner
|
I don't think this is right. Files can have a different encoding and we should support that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #37, I found a file that triggered the error, it was a
._*macOS resource fork.My proposed fix is to check the encoding:
And if invalid, fix it:
I added my dodgy resource file to the fixtures, it broke the tests [without the new code]. I also added some invalid bytes to
unused_class.hto check existing tests pass.All tests pass. I built the gem and ran against my project with the resource fork, and it worked fine.