Skip to content

Fix flaky lost spec when fabricated user names collide #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dblock merged 1 commit into from
Apr 5, 2026
Merged

Fix flaky lost spec when fabricated user names collide #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/slack-gamebot/commands/lost_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@

context 'lost to' do
let(:loser) { Fabricate(:user, user_name: 'username') }
let(:winner) { Fabricate(:user) }
let(:winner) { Fabricate(:user, user_name: 'winner') }

it 'a player' do
expect do
Expand All @@ -160,8 +160,8 @@
end

it 'two players' do
winner2 = Fabricate(:user, team:)
loser2 = Fabricate(:user, team:)
winner2 = Fabricate(:user, team:, user_name: 'winner2')
loser2 = Fabricate(:user, team:, user_name: 'loser2')
expect do
expect do
expect(message: "#{SlackRubyBot.config.user} lost to #{winner.user_name} #{winner2.user_name} with #{loser2.user_name}", user: loser.user_id, channel: 'pongbot').to respond_with_slack_message(
Expand All @@ -175,8 +175,8 @@
end

it 'two players with scores' do
winner2 = Fabricate(:user, team:)
loser2 = Fabricate(:user, team:)
winner2 = Fabricate(:user, team:, user_name: 'winner2')
loser2 = Fabricate(:user, team:, user_name: 'loser2')
expect do
expect do
expect(message: "#{SlackRubyBot.config.user} lost to #{winner.user_name} #{winner2.user_name} with #{loser2.user_name} 15:21", user: loser.user_id, channel: 'pongbot').to respond_with_slack_message(
Expand Down
Loading