Skip to content

fix(packets): Clear Filters must reset observer and type selection state #121

Description

@dborup

Problem

The Packets page keeps observer and packet-type selections in closure-owned selectedObservers and selectedTypes Sets. Clear Filters resets filters, local storage, and visible checkboxes, but does not clear those Sets and leaves the “All” entries visually unchecked.

The next observer/type click can therefore restore stale selections that appeared to have been removed.

Upstream reference: Kpa-clawbot/CoreScope#2015.

Acceptance criteria

  • Clear both internal Sets and rebuild their menus from an empty state.
  • “All Observers” and “All Types” are checked, with matching trigger labels/titles.
  • URL, local storage, and filters retain no stale observer/type values.
  • Existing hash, node, channel, language, time-window, region, and My Nodes filter behavior remains unchanged.
  • Clear causes the appropriate packet reload/render exactly once.

Regression test

Select observer A and a type, clear, then select B/a different type and prove A/the old type does not return anywhere. Also cover repeated clears and SPA remounting.

Non-goals

No control redesign, API/database change, or deploy.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions