You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(channels): auto-approved channel does not appear in the suggesting tab until the next list refresh #232
With channelProposals.autoApprove on (#196), a suggested channel is approved at once. The suggesting tab, however, only updates its status line ("… is already shared with everyone.") and does not refresh its channel list.
onApproved, which runs loadChannels(true), is called only from the admin decision path, not from the suggest poller.
So the auto-approved channel shows up in that tab only at the next list refresh. The proposals E2E checks it on a second page after a reload.
Found in the #153 review. It is not a regression: nothing is refreshed, so an open PSK conversation is not at risk.
Proposed fix
When the suggest poller sees the status approved, call the same onApproved path. With #153 merged, loadChannels() keeps client-only state across the refresh.
Acceptance
With auto-approve on, the suggested channel appears in the suggesting tab's list without a reload.
An open PSK conversation and the unread counts survive that refresh.
A unit test for the poller's approved path, and an E2E step in the proposals test that checks the same page.
When the suggest poller sees approved, it now runs the same onApproved refresh as the admin path. An auto-approved channel therefore appears in the suggesting tab without a reload, and the client state from #153 survives. Exactly one /channels refresh happens per approval.
Follow-up from the review: an api() in-flight coalescing edge case and a missing unmount() test are tracked separately.
Activity
Merge pull request #238 from dborup/codex/issue-232-autoapprove-refresh
dborup commentedon Oct 5, 2026
Fixed by #238 (merged as
8d8940a6).When the suggest poller sees
approved, it now runs the sameonApprovedrefresh as the admin path. An auto-approved channel therefore appears in the suggesting tab without a reload, and the client state from #153 survives. Exactly one/channelsrefresh happens per approval.Follow-up from the review: an
api()in-flight coalescing edge case and a missingunmount()test are tracked separately.