Skip to content

fix(channels): auto-approved channel does not appear in the suggesting tab until the next list refresh #232

Closed

Description

@dborup

Relates to #196, #153

Problem

With channelProposals.autoApprove on (#196), a suggested channel is approved at once. The suggesting tab, however, only updates its status line ("… is already shared with everyone.") and does not refresh its channel list.

  • onApproved, which runs loadChannels(true), is called only from the admin decision path, not from the suggest poller.
  • So the auto-approved channel shows up in that tab only at the next list refresh. The proposals E2E checks it on a second page after a reload.

Found in the #153 review. It is not a regression: nothing is refreshed, so an open PSK conversation is not at risk.

Proposed fix

When the suggest poller sees the status approved, call the same onApproved path. With #153 merged, loadChannels() keeps client-only state across the refresh.

Acceptance

  • With auto-approve on, the suggested channel appears in the suggesting tab's list without a reload.
  • An open PSK conversation and the unread counts survive that refresh.
  • A unit test for the poller's approved path, and an E2E step in the proposals test that checks the same page.

Activity

  1. added a commit that references this issue on Oct 5, 2026
  2. dborup commented on Oct 5, 2026

    @dborup
    OwnerAuthor

    Fixed by #238 (merged as 8d8940a6).

    When the suggest poller sees approved, it now runs the same onApproved refresh as the admin path. An auto-approved channel therefore appears in the suggesting tab without a reload, and the client state from #153 survives. Exactly one /channels refresh happens per approval.

    Follow-up from the review: an api() in-flight coalescing edge case and a missing unmount() test are tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions