Skip to content

Follow-up to #297: pin a merge that moves first_seen and changes the path; stale Hash in distance index after a no-move rehash #303

Closed

Description

@dborup

From the review of #297 (#288, merged).

  1. Test gap. No test covers a merge that moves first_seen and changes the path. The XOR mutant pathChanged != moved survives all current tests, and it would leave that survivor's distance records stale. Add a test.
  2. Pre-existing. A rehash where neither the path nor first_seen moves leaves the old Hash in distHops/distPaths until the next full build. Decide whether to refresh the hash too, or document why it is harmless.
  3. Wording in fix(server): refresh distance index when a merge moves FirstSeen (#288) #297. Before the lazy distance build has run, updateDistanceIndexForTxs still appends records for the listed survivors into the unbuilt index. Check that this is harmless, or skip it while the index is unbuilt.

Activity

  1. added a commit that references this issue on Oct 6, 2026
  2. dborup commented on Oct 6, 2026

    @dborup
    OwnerAuthor

    Fixed by #312 (merged as 435f5ade8018020dd1281a3973577709c40c2642).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesttype:choreMaintenance, refactoring, cleanup

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions