From the review of #298 (#284, merged).
TestHandleClientPacketMinimisedAndWholeAgree cannot detect a dropped minimised packet. The whole packet alone writes the one expected row, so every "payload required" mutant stays green. Assert the minimised packet on its own, for example by sending it first with a distinct rx_at and asserting its row.- Pin the three documented claims with tests:
- a minimised 0-hop advert is dropped;
- a minimised relayed advert survives;
- a partially kept payload is tolerated.
- Fix the trivial line reference in the test comment: at firmware
a366955, the PAYLOAD_TYPE_* defines are on lines 19–32.
From the review of #298 (#284, merged).
TestHandleClientPacketMinimisedAndWholeAgreecannot detect a dropped minimised packet. The whole packet alone writes the one expected row, so every "payload required" mutant stays green. Assert the minimised packet on its own, for example by sending it first with a distinctrx_atand asserting its row.a366955, thePAYLOAD_TYPE_*defines are on lines 19–32.