Follow-up to #319 (#273), from the review of #319. The same tie-order bug class as #256/#293/#273: count-only sorts over map iteration with no secondary key, so tied entries come out in a random order on each call. All of them are shown to the user.
| Site |
List |
Cap |
Frontend |
cmd/server/node_analytics_summary.go:409 |
peerInteractions |
20 (random cut) |
public/node-analytics.js:152 |
cmd/server/node_analytics_summary.go:391 |
observerCoverage |
none |
public/node-analytics.js:249 |
cmd/server/store.go:10521 |
observerRows (GetNodeHealth) |
none |
public/live.js:2694 |
cmd/server/store.go:10353 |
observerRows (GetBulkHealth) |
none |
same shape |
Lower priority, same shape: cmd/server/store.go:9569 (collisions) sorts on class order, then Appearances, with no final key.
The peerInteractions cap makes the first site the most visible. With ties at the cut-off, which peers are shown changes between calls, not just their order.
Acceptance
Line numbers are from origin/master at 2820d18d and may drift.
Follow-up to #319 (#273), from the review of #319. The same tie-order bug class as #256/#293/#273: count-only sorts over map iteration with no secondary key, so tied entries come out in a random order on each call. All of them are shown to the user.
cmd/server/node_analytics_summary.go:409peerInteractionspublic/node-analytics.js:152cmd/server/node_analytics_summary.go:391observerCoveragepublic/node-analytics.js:249cmd/server/store.go:10521observerRows(GetNodeHealth)public/live.js:2694cmd/server/store.go:10353observerRows(GetBulkHealth)Lower priority, same shape:
cmd/server/store.go:9569(collisions) sorts on class order, thenAppearances, with no final key.The
peerInteractionscap makes the first site the most visible. With ties at the cut-off, which peers are shown changes between calls, not just their order.Acceptance
rankSubpaths(Reapply #261: deterministic order for tied Hash Stats adopters (#256) #293) and fix(server): deterministic tie order in GetSubpathDetail (#273) #319.Line numbers are from
origin/masterat2820d18dand may drift.