Skip to content

Pin the fifth route_mask merge evidence term: loser's re-parented observation headers (#295 follow-up) #324

Closed

Description

@dborup

Follow-up to #295 (#287, merged as de6e83b4), from the round-3 review of #295, finding 1. It did not block the merge.

recomputeMergedRouteMask combines five evidence terms. The fifth is the header bits of the loser's observations after they are re-parented onto the survivor. That term is still not pinned by a test.

Mutant N2. Move recomputeMergedRouteMask above the UPDATE OR IGNORE observations move, so the scan only sees the survivor's own rows. N2 survives the full cmd/ingestor suite.

Probe RZ1:

  • the survivor is computed FLOOD, with one FLOOD observation;
  • the loser has route_mask NULL and route_type FLOOD, with one surviving DIRECT observation, so the loser's observation header is the only DIRECT evidence.
Tree Result
head 6
N2 2
master 2

N2 is not worse than master, but for this shape it silently rolls the fix back.

Acceptance

  • A test with the RZ1 shape, where the loser's re-parented observation header is the only evidence for a bit. It is red under N2 and green on master.
  • Test-only.

Activity

  1. added a commit that references this issue on Oct 7, 2026
  2. dborup commented on Oct 7, 2026

    @dborup
    OwnerAuthor

    Fixed by #328 (merged as 9205f56e12e8171c95af04f45356e6d7a0031589).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions