Skip to content

Follow-ups to #366: dark legacy tile override, legacy attribution, zoom cap #390

Closed

Description

@dborup

Follow-ups from the review of #366 (#364, merged).

  1. Dark legacy override is still masked. tiles.dark / map.tiles.darkUrl is overridden by the registry default the same way the light override was before fix(maps): preserve legacy light tile URL overrides (#364) #366. No legacy branch exists for dark. Mirror the fix(maps): preserve legacy light tile URL overrides (#364) #366 precedence (explicit choice > configured default > legacy URL > built-in fallback) for dark.
  2. Attribution for legacy raw URLs. A legacy URL carries no vendor metadata, so e.g. an OpenTopoMap URL gets the generic © OpenStreetMap contributors credit (missing CC-BY-SA/SRTM). Consider allowing an attribution override alongside the legacy URL, or document it.
  3. Zoom cap. The legacy-URL spec hard-codes maxZoom 18 (osm-standard), so a custom provider that supports z19 is clipped one level. Consider a configurable max zoom.

Activity

  1. added a commit that references this issue on Oct 13, 2026
  2. dborup commented on Oct 13, 2026

    @dborup
    OwnerAuthor

    Fixed by #399 (merged as 1aaa41c959ad4784a29c45f475a582bac6715e36). Remaining nits from the review on #399: the config.example.json note says legacy URLs cap at z18 but the map requests z19 (docs wording), and the dark-id type guard that now decides legacy precedence is not pinned by a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions