Skip to content

ops: make the bundled Mosquitto opt-in, normalise DISABLE_MOSQUITTO, pprof loopback by default (#431 owner decisions) #441

Closed

Description

@dborup

Owner decisions (2026-10-14) on the "Left for the owner" items in #431 (#372, merged):

  1. The bundled Mosquitto becomes opt-in. The default in docker-compose.yml (and every other compose variant or script default) changes to DISABLE_MOSQUITTO=true. Operators who rely on the bundled broker must set DISABLE_MOSQUITTO=false explicitly. Ship this with a clear release note.
  2. Normalise DISABLE_MOSQUITTO parsing. The entrypoint, Go code and manage.sh must treat true/1/yes/on (case-insensitive, trimmed) identically, and likewise false/0/no/off. broker-check stops reporting a mismatch once parsing is consistent; it should still report the effective mode.
  3. pprof binds to loopback by default when enabled. When ENABLE_PPROF is on, the server and ingestor listeners default to 127.0.0.1. The existing PPROF_BIND setting restores remote access (e.g. PPROF_BIND=0.0.0.0). Keep distinct server/ingestor ports. Document the SSH-tunnel alternative.
  4. MQTT_SOURCE_STRICT stays off by default. No change.

Acceptance:

  • Tests for each parsing value (including unset/empty and junk), the compose default, and the pprof bind default and override.
  • Release note text covering what changes on upgrade and how to keep the old behaviour (DISABLE_MOSQUITTO=false, PPROF_BIND=0.0.0.0).
  • Verified with local Docker that an install with DISABLE_MOSQUITTO=true (as all our deployments have) behaves identically before and after.

Activity

  1. added a commit that references this issue on Oct 14, 2026
  2. dborup commented on Oct 14, 2026

    @dborup
    OwnerAuthor

    Fixed by #444 (merged as 38776c46a80a1adf005fd47dddfc441b0f0e2d29). Owner accepted F1 from the review: remote pprof access is restored with PPROF_HOST=0.0.0.0 (process listen address); PPROF_BIND only affects the staging compose port publishing. Remaining nits (F2-F4) are recorded in the review on #444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions