Skip to content

fix(mobile): Regions page is unreachable from the bottom-nav More sheet #454

Closed

Description

@dborup

Problem

The Regions page added in #376 cannot be reached on phones. At widths of 768px and below, the top nav and the hamburger are hidden and the bottom nav takes over. The bottom nav's "More" sheet uses a hardcoded MORE_ROUTES list in public/bottom-nav.js, and regions was never added to it.

The page itself works on mobile when opened directly at #/regions. Verified at a 375×812 viewport: the map renders at full width, tiles load and markers are shown.

Fix

  • Add { route: 'regions', hash: '#/regions', label: 'Regions', ph: 'globe' } to MORE_ROUTES. Put it before nodes, so the sheet follows the top-nav order.
  • Update EXPECTED_MORE_ROUTES in test-bottom-nav-1061-e2e.js.
  • Add a guard test that fails when a static top-nav data-route in public/index.html is in neither the bottom-nav TABS nor MORE_ROUTES. That stops the next new page from repeating this.
    • The opt-in routes Coverage and Privacy are injected at runtime and are already handled.
    • The test must not use a hand-maintained copy of the route list.

Acceptance criteria

At ≤768px, the More sheet lists Regions, and tapping it opens the map. Desktop is unchanged.

Activity

  1. dborup commented on Oct 15, 2026

    @dborup
    OwnerAuthor

    Fixed by #455 (merged as 6f613a2b1033497921ad95fa88ab07c0290b14d0).Fixed by #455: Regions is in the mobile More sheet, with a guard test that every top-nav route is reachable on phones (APPROVE by independent review, CI green).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions