Skip to content

regions: trim back to the first Regions PR (#501) — revert #502, #503, #505, #507, #510 #523

Closed

Description

@dborup

Decision

The extra Regions views added after the first Regions PR cost too much memory and CPU for what they deliver. On staging, RSS rose by about 150–300 MB, and the 5-minute relay snapshot recompute now walks every transmission and observation to build history, routes, membership and evidence. Payloads are history 1.1 MB raw / 141 KB gzip and routes 5.4 MB raw / 679 KB gzip.

The owner has decided to keep only the first Regions PR (#501, the Latest view with 1h/24h/7d windows and coverage) and remove the rest.

Remove (revert the merge commits, newest first)

PR Merge What
#510 6fe9603 Budget redesign and capture diagnostics
#507 45c9607 Per-bucket/per-scope evidence, membership capture
#505 c6574b4 Connections view, /api/regions/routes, StoreObs transport fields
#503 9933d05 Health & trends
#502 5ff889d Timeline and period comparison, /api/regions/history

Keep

Notes

Acceptance

  • One PR containing the five reverts plus the re-applied CI-shard coverage change.
  • No remaining references to /api/regions/history or /api/regions/routes, or to regions-history.js / regions-routes.js, in the server, frontend, index.html, OpenAPI or docs.
  • The Regions page on desktop and mobile shows Latest with windows and coverage, and has no dead tabs or controls.
  • cmd/server and cmd/ingestor go test ./... pass, including -race on the regions, store and load tests. The frontend unit tests pass, and so do E2E for regions and home/My Mesh.
  • The perf(store): move runtime SQL outside packet-store locks #495 lock rule (no SQL under PacketStore.mu) still holds.
  • The PR description includes a perf justification. The coordinator measures RSS and the relay recompute time on staging before and after.

Activity

  1. dborup commented on Oct 23, 2026

    @dborup
    OwnerAuthor

    Fixed by #524 (merged as 0350322e6cd0be6aad5d507f4e033e411402d7bc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions