Conversation
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port upstream
Kpa-clawbot/CoreScope#2102to this fork: cache/api/nodes?region=node membership by normalized region set, reuse it across count/page requests, refresh additions incrementally after 30 seconds, and rebuild fully every 30 minutes for retention and IATA changes.Fork-specific changes
from_pubkeybackfill is incomplete: fall back todecoded_json.pubKeyfor rows whosefrom_pubkeyis NULL.Performance and behavior
TestNodeRegionCachePortMembershipAndReuseenforces one scan across three equivalent region requests.Verification
cmd/serverGo test suite andgo vet ./...passed locally.-race.cmd/ingestorGo test suite passed locally. The first sandboxed run could not bind the local MQTT test sockets; rerunning with local test sockets allowed passed.This is a port for review, not a deployment. No issue-closing keywords or auto-merge.
Related open PR #38 also changes the Nodes region query to use
from_pubkey; review its overlap before merging either PR.