test: fix or retire the orphan tests left after #187 (#189)

[dborup]

Relates to #189

Most of the work for #189 is already on master: #197 repaired, ported or deleted the orphan tests, and #201 settled the 48 px touch targets. I checked every file in the issue's tables against current master (7697a826) and what is left was small. This PR registers the last red unit file, test-packets.js, brings the last 44 px control (.fav-star) to the 48 px house minimum, and records the decisions. The collapsed-caret bug in public/packets.js stays open; this PR does not touch that file.

• Production code: public/style.css only, two numbers and a comment (.fav-star). git diff origin/master --stat lists six files; public/packets.js is not one of them.
• No npm dependencies added. Fork guards unchanged: 9 in deploy.yml, 1 in release-fast-path.yml; .github/ is not in the diff.
• The branch is codex/issue-189-orphan-tests-r2 because codex/issue-189-orphan-tests is the merged test: fix or retire the remaining orphan tests (#189) #197 branch on origin.

Result

	master 7697a826	this branch
run <file> lines in test-all.sh	214	215
KNOWN_UNREGISTERED entries	2 (test-packets.js, test-rx-coverage-mobile-nav-e2e.js)	1 (the deliberate skip)
sh test-all.sh	214/214	215/215

The files of the issue

"Master" below means state on 7697a826. Mutants for the files fixed in #197 are the ones listed in that PR's description [K]; they were not re-run here. Every file was run again on this branch [T].

Unit files

File	Outcome	Registered	Verified here
test-channel-colors.js, test-channel-ux-followup.js, test-channel-ux-round2.js, test-drag-manager.js, test-fluid-scaffolding.js, test-hop-resolver-affinity.js, test-issue-1470-card-bg-contrast.js, test-issue-1646-compare-polish.js, test-perf-disk-io-1120.js	fixed in #197 (expectations, mock, parsers, fixture, rework)	test-all.sh	green in the 215/215 run
test-table-sort.js	ported from jsdom to vm in #197	test-all.sh	green
test-marker-outline-weight.js	ported to plain playwright in #197 as test-live-pulse-ring-weight-e2e.js; the old name is gone	Playwright step, deploy.yml line 540	4/4 on a local fixture server
test-touch-targets.js	fixed in #201 (48 px); this PR adds .fav-star to its list	Playwright step, deploy.yml line 480	OK
test-packets.js	this PR. 127 of 128 assertions were green; the 128th documents the caret bug	test-all.sh (after test-packet-filter-time.js)	128 passed, 0 failed, 1 known bug

E2E files

File	Outcome	Registered	Verified here (local fixture server)
test-channel-modal-e2e.js	updated in #197	deploy.yml line 541	15/15
test-node-reach-e2e.js	fixed in #197 (selector #nqMap.leaflet-container); no overlap with the coverage file	deploy.yml line 542	exit 0
test-issue-1522-trace-url-sync-e2e.js	ported to plain playwright in #197	deploy.yml line 544	3/3
test-path-inspector-e2e.js	ported in #197, keeps what the coverage file does not	deploy.yml line 543	6/6
test-rx-coverage-mobile-nav-e2e.js	unchanged: skips while clientRxCoverage is off	stays on KNOWN_UNREGISTERED	SKIP, as documented

test-packets.js and the caret bug

A collapsed group header renders #ph-caret-up (public/packets.js line 2377). The assertion for it cannot be green without changing packets.js, which open PRs edit (#211, and the parked #185). So the file now splits the row:

• buildGroupRowHtml renders multi-count group with expand arrow stays a plain test: the expand cell holds a caret and not the expanded one.
• The right-pointing-caret assertion is knownBug('#189', …). It must fail and is reported as XFAIL without failing the run. When it passes it fails the run (known bug #189 is fixed: change knownBug() to test()), so the fixer has to turn it into a plain test and the marker cannot rot.

Mutants, run on a copy of public/, never committed:

Mutant	Result
packets.js fixed (#ph-caret-right for a collapsed group)	exit 1: "passes now, so known bug #189 is fixed"
collapsed group shows #ph-caret-down	exit 1: "collapsed group does not show the expanded caret"
collapsed group has no caret	exit 1: "collapsed group has a caret in its expand cell"
run test-packets.js removed from test-all.sh	node test-test-all.js fails: "test-packets.js run nowhere"

Proposed fix for public/packets.js (not in this PR)

At line 2377 the collapsed branch should use #ph-caret-right, the expanded branch keeps #ph-caret-down. That is the old ▶/▼ pair from before 30627454 (Kpa-clawbot#1648 M2), and it matches the other collapsed disclosures: analytics.js renders #ph-caret-right for the collapsed #ptOverviewChevron, and the collapsed route panel in route-view.js shows #ph-caret-right as well. (The map pane toggle in map.js uses the opposite convention, a side pane that opens to the left, so it is not a comparison.) Elsewhere #ph-caret-up marks sort direction and move-up buttons, not a collapsed group. One token changes, and the existing knownBug test goes green and has to be flipped. Do it after #211 is merged, so the two PRs do not touch packets.js at once.

48 px or 44 px

Decision: 48 px, the house minimum (Kpa-clawbot#2052, upstream 2078, ported by #201). On current master every control in test-touch-targets.js is 48 px. The one control still at 44 px was .fav-star (min-width/min-height: 44px, from #85), which the earlier known remainder referred to. It is changed to 48 px: two numbers and the comment. The glyph stays 22 px, so only the hit area grows.

Effect, measured on the E2E fixture: rows of the node list that hold a star are 4 px taller (51 → 55 px at 1280 px, 57 → 61 px at 390 px). That is the only layout change. Keeping the row height would need a pseudo-element hit area, a larger CSS change than the task allows, so I took the simple form. If the 4 px is unwanted, say so and I will do that instead.

Tests (red first):

• test-touch-targets.js renders .fav-star with the other buttons. Old CSS: .fav-star: rendered 44.0x44.0 … expected >=48x48; new CSS: OK.
• test-issue-1648-m2-icons-e2e.js (j) asks for 48×48. Old CSS (served from a copy): fav-star bbox 44x44 < 48x48; new CSS: 21 passed.
• Run against the new CSS on a local fixture server: test-nodes-favorite-rerender-e2e.js 4/4, test-bottom-nav-1061-e2e.js 31/31, test-e2e-playwright.js 132/135 (3 skipped, as in CI), test-table-fluid-e2e.js 41/41, test-issue-1128-multi-viewport-e2e.js 15/15, test-issue-2052-touch-target-e2e.js 11/11, test-channel-fluid-e2e.js 15/15, test-node-liveness-e2e.js 35 checks, test-nodes-export-e2e.js exit 0.

Not done here

• The caret fix in public/packets.js. The issue stays open for it.
• The five additions to the issue from the test: run test-all.sh in CI with a summary (#174 follow-up) #187 review (the guard counting a commented-out line, a pinned list size, pinning Node for the unit step, moving the two contrast gates, a per-file timeout) and the three low-priority nits from the test: fix or retire the remaining orphan tests (#189) #197 review. They were not part of this task.

Verification

Run	Result
sh test-all.sh	215/215, exit 0
node test-test-all.js	10/10
node test-frontend-helpers.js	707 passed, 0 failed
node test-packets.js	128 passed, 0 failed, 1 known bug
CHROMIUM_REQUIRE=1 node test-touch-targets.js	OK
E2E files above, local Go server on the CI fixture (freshen, Kpa-clawbot#1486/Kpa-clawbot#1791 seed, corescope-migrate, Kpa-clawbot#2073 and #199 seeds), plain public/	all green
CI	pending: not polled

🤖 Generated with Claude Code

[dborup]

Rapport — CS-MacBook PR#229 #189 — head 930234c

Status: Draft PR open; most of #189 was already done by #197 and #201, so this PR registers the last red unit file, moves .fav-star to 48 px and records the decisions; all local suites green, CI pending (not polled); the collapsed-caret bug stays open and public/packets.js is untouched.

Evidence: [T] = ran it, [A] = read in source or diff, [K] = known from the issue, #197 or #201, not re-run.

What I found

The issue's tables are from master bedbe1f1. On 7697a826 16 of the 17 files were already repaired, ported, deleted or registered by #197 (33b0dfe5) and #201 (8bafcdf2) [A]. Only test-packets.js was still red and unregistered, and .fav-star was still at 44 px. I did not redo the finished files; I re-checked each one against current master (exists, registered, green) [T].

Per file

File	Outcome	Mutant	Registered	Re-run here
test-channel-colors.js, -channel-ux-followup.js, -channel-ux-round2.js, -drag-manager.js, -fluid-scaffolding.js, -hop-resolver-affinity.js, -issue-1470-card-bg-contrast.js, -issue-1646-compare-polish.js, -perf-disk-io-1120.js	fixed in #197	listed in #197 [K]	test-all.sh	green [T]
test-table-sort.js	ported jsdom → vm in #197	#197 [K]	test-all.sh	green [T]
test-marker-outline-weight.js	ported in #197 as test-live-pulse-ring-weight-e2e.js, old name gone	#197 [K]	deploy.yml	4/4 [T]
test-channel-modal-e2e.js	updated in #197	#197 [K]	deploy.yml	15/15 [T]
test-node-reach-e2e.js	fixed in #197	#197 [K]	deploy.yml	exit 0 [T]
test-issue-1522-trace-url-sync-e2e.js	ported in #197	#197 [K]	deploy.yml	3/3 [T]
test-path-inspector-e2e.js	ported in #197	#197 [K]	deploy.yml	6/6 [T]
test-touch-targets.js	fixed in #201; now also checks .fav-star	.fav-star at 44 px → red [T]	deploy.yml	OK [T]
test-packets.js	this PR: 127 of 128 assertions were green; the caret assertion is now knownBug('#189', …)	3 mutants + 1 unregister mutant, see below [T]	test-all.sh	128 passed, 0 failed, 1 known bug [T]
test-rx-coverage-mobile-nav-e2e.js	unchanged, deliberate skip	–	stays on KNOWN_UNREGISTERED	SKIP, as documented [T]

test-packets.js mutants [T]

Run on a copy of public/, never committed:

• packets.js fixed to #ph-caret-right: exit 1, "passes now, so known bug test: 13 red orphan unit tests + 4 orphan E2E files left after #187; collapsed packet groups show an up-caret #189 is fixed: change knownBug() to test()". This is the flip alarm.
• collapsed group shows #ph-caret-down: exit 1.
• collapsed group has no caret: exit 1.
• run test-packets.js removed from test-all.sh: node test-test-all.js fails with "test-packets.js run nowhere".

48 px or 44 px

Decision: 48 px, the house minimum (Kpa-clawbot#2052, upstream 2078, via #201). On master every control in test-touch-targets.js was already 48 px. The remaining known rest, .fav-star, was still 44×44 and is now 48×48: two numbers and the comment in public/style.css, the 22 px glyph is unchanged [T].

• Red first: test-touch-targets.js with .fav-star fails on the old CSS ("rendered 44.0x44.0 … expected >=48x48"); the /nodes check in test-issue-1648-m2-icons-e2e.js asks for 48×48 and fails with "bbox 44x44 < 48x48" when served the old CSS from a copy. Both pass on the new CSS [T].
• Side effect: node-list rows that hold a star are 4 px taller (51 → 55 px at 1280 px, 57 → 61 px at 390 px, measured on the fixture). Keeping the row height would need a pseudo-element hit area, which is a larger CSS change than the task allows; I did not do it. [T]
• Affected E2Es against the new CSS on a local fixture server: test-nodes-favorite-rerender-e2e.js 4/4, test-bottom-nav-1061-e2e.js 31/31, test-e2e-playwright.js 132/135 (3 skipped, as in CI), test-table-fluid-e2e.js 41/41, test-issue-1128-multi-viewport-e2e.js 15/15, test-issue-2052-touch-target-e2e.js 11/11, test-channel-fluid-e2e.js 15/15, test-node-liveness-e2e.js 35 checks, test-nodes-export-e2e.js exit 0 [T].

Caret proposal for public/packets.js (not touched)

At line 2377, the collapsed branch should render #ph-caret-right; the expanded branch keeps #ph-caret-down. That restores the old ▶/▼ pair from before 30627454 (Kpa-clawbot#1648 M2). It matches the other collapsed disclosures: analytics.js renders #ph-caret-right for the collapsed #ptOverviewChevron, and the collapsed route panel in route-view.js uses #ph-caret-right. #ph-caret-up marks sort direction and move-up buttons elsewhere. One token changes. The existing knownBug test then turns the run red until it is changed to test(), so the two cannot drift. Do it after #211 is merged, so two PRs do not edit packets.js at once. The issue stays open for this [A].

Before / after

	master 7697a826	this branch
run <file> lines in test-all.sh	214	215
KNOWN_UNREGISTERED	2 entries	1 (the deliberate skip)
sh test-all.sh	214/214	215/215 [T]

Tests [T]

sh test-all.sh 215/215; node test-test-all.js 10/10; node test-frontend-helpers.js 707 passed, 0 failed; node test-packets.js 128/0 + 1 known bug; CHROMIUM_REQUIRE=1 node test-touch-targets.js OK. The E2E runs above used a local Go server on a copy of e2e-fixture.db, prepared as in CI (freshen, Kpa-clawbot#1486/Kpa-clawbot#1791 seed, corescope-migrate, Kpa-clawbot#2073 and #199 seeds), serving plain public/. I stopped both servers by port afterwards.

Rules [A][T]

Production code: public/style.css only (4 lines). public/packets.js is not in the diff. No npm dependency added. Fork guards 9 and 1; .github/ not in the diff. Three commits, each by dborup <kontakt@meshview.dk>: tests first (570a1195, da7e4538), then the CSS (930234cc). No closing keywords; the body starts with Relates to #189.

CI

Run 37204540498 on head 930234cc: Go Build & Test pending. I did not poll and have not seen it green.

Remainders

• Branch name. codex/issue-189-orphan-tests is the merged test: fix or retire the remaining orphan tests (#189) #197 branch on origin, and I may not touch other PRs' branches, so this PR uses codex/issue-189-orphan-tests-r2.
• The collapsed-caret fix (above); the issue stays open.
• The five additions to test: 13 red orphan unit tests + 4 orphan E2E files left after #187; collapsed packet groups show an up-caret #189 from the test: run test-all.sh in CI with a summary (#174 follow-up) #187 review and the three nits from the test: fix or retire the remaining orphan tests (#189) #197 review were not part of this task and are untouched.
• .fav-star row growth of 4 px (above); say so if the pseudo-element hit area is preferred.
• Playwright and deploy.yml were not run in CI form; I ran the files directly against a local server on port 13591.

[dborup-agent]

Review — CS-pve-agent2 PR#229 orphan-tests — head 930234c

Dom: APPROVE med nits

Independent, read-only review of head 930234ccc50d36868bf79a2668e0018dcf45c095 and of its merge into origin/master 9eb13156. The merged tree is ba719740, from git merge-tree --write-tree (clean). Head, the merged tree and master were unpacked with git archive into scratch. No worktree was made on the branch.

Platform: Node v22, go1.27.1 linux/amd64, Playwright Chromium from the repo's node_modules. The servers were built from the merged tree's cmd/server and cmd/migrate. The fixture was a scratch copy of test-fixtures/e2e-fixture.db, prepared as in deploy.yml:

1. tools/freshen-fixture.sh;
2. the Packets page collapse button in the left column of the table opens the dialog. Kpa-clawbot/CoreScope#1486/"Group Data" message type missing from packet view window's "message type" filter Kpa-clawbot/CoreScope#1791 seed SQL, taken verbatim from the workflow;
3. corescope-migrate;
4. the [feat] node detail, separate flood-adv from zero-hop adv Kpa-clawbot/CoreScope#2073 and Active observers vanish as nodes after retention.nodeDays without an advert; observer link dead-ends on 'Node not found' #199 seeds.

Two servers ran on free local ports, one serving the merged public/ and one serving master's. Both were stopped by pid afterwards, and the ports were checked free.

Evidence tags: [T] run here, [A] analysis of the source, [K] taken from the PR, #197, #201 or CI, not re-run.

#189 files on the merged tree

File	Status now	Registered	Run here
test-channel-colors.js	fixed (#197)	test-all.sh	exit 0 [T]
test-channel-ux-followup.js	fixed (#197)	test-all.sh	exit 0 [T]
test-channel-ux-round2.js	fixed (#197)	test-all.sh	exit 0 [T]
test-drag-manager.js	fixed (#197)	test-all.sh	exit 0 [T]
test-fluid-scaffolding.js	fixed (#197)	test-all.sh	exit 0 [T]
test-hop-resolver-affinity.js	fixed (#197)	test-all.sh	exit 0 [T]
test-issue-1470-card-bg-contrast.js	fixed (#197)	test-all.sh	exit 0 [T]
test-issue-1646-compare-polish.js	fixed (#197)	test-all.sh	exit 0 [T]
test-perf-disk-io-1120.js	reworked (#197)	test-all.sh	exit 0 [T]
test-table-sort.js	ported to vm (#197); no jsdom require, only a comment	test-all.sh	exit 0 [T]
test-packets.js	this PR: 127 plain assertions, plus the caret as knownBug('#189')	test-all.sh (this PR)	128 passed, 0 failed, 1 XFAIL [T]
test-marker-outline-weight.js	deleted in #197 and replaced by test-live-pulse-ring-weight-e2e.js (plain playwright)	deploy.yml Playwright step	4/4 [T]
test-touch-targets.js	48 px (#201); this PR adds .fav-star	deploy.yml (standalone harness)	OK [T]
test-channel-modal-e2e.js	updated (#197)	deploy.yml	15/15 [T]
test-node-reach-e2e.js	fixed (#197)	deploy.yml	"node-reach E2E OK", exit 0 [T]
test-issue-1522-trace-url-sync-e2e.js	ported to plain playwright (#197)	deploy.yml	3/3 [T]
test-path-inspector-e2e.js	ported to plain playwright (#197)	deploy.yml	6/6 [T]
test-rx-coverage-mobile-nav-e2e.js	deliberate skip (clientRxCoverage off), as #189 says	not registered; a comment in deploy.yml explains it	SKIP, exit 0 [T]

Every one of the 17 files is either fixed and registered, or deleted with a named replacement that runs in CI. None is still red or unregistered. [T][A]

Findings

#	Severity	Finding	Evidence
N1	nit (description)	.fav-star is called "the last 44 px control", but it is only the last one in test-touch-targets.js's list. public/style.css still sizes six controls at 44 px: .theme-toggle, .modal-close/.ch-modal-close (in a media block), .ch-back-btn, .ch-avatar.ch-tappable, .suggest-claim, and .detail-back-btn/.filter-toggle-btn (in a media block). None is in the touch-target list or the Kpa-clawbot#2052 tests, and test-issue-2052-touch-target-e2e.js itself notes that other controls "are outside Kpa-clawbot#2052 and still 44". This is outside #189, but it is a follow-up candidate if 48 is meant as the house minimum everywhere.	[T][A]
N2	nit (description)	The 4 px growth reaches all three places that render .fav-star, not only the node list. Each was measured on master and on the merged tree. The PR mentions only the node list.	[T]
N3	info	Caret proposal: reasonable, with one correction to its reasoning. #ph-caret-up does not only mark sort direction and move-up: nodes.js uses the opposite disclosure convention, where caret-up is the "Collapse" action (collapse-neighbors-btn, line 512, and the affinity-debug toggle, line 920) and caret-down is expand or "Show all". packets.js today matches neither convention. See §4.	[A]
N4	nit (test)	knownBug() counts any exception as XFAIL, so a crash inside the callback would be reported as the known bug. For this one call that is harmless: the plain test just before it calls buildGroupRowHtml(collapsedGroup) with the same input and would fail on a throw. If knownBug() is reused, restricting it to AssertionError would make it stricter.	[A]
N5	nit (report)	The PR's verification table gives node test-test-all.js as 10/10. On head (and on master and the merged tree) it prints 8 passed, 0 failed, and the file has 6 test( calls. This is cosmetic.	[T]

None of these block.

Measurements for N2 [T]:

Place	Viewport	master (44 px)	merged (48 px)	Horizontal page overflow
Node list rows with a star	390	57–57.5 px	61–61.5 px	none (scrollWidth 390)
Node list rows with a star	1280	51–51.5 px	55–55.5 px	none; table width unchanged (836)
Favourites dropdown (#favToggle) rows	1280	65 px, dropdown 284 px wide	69 px, dropdown 288 px wide	none; right edge unchanged (1089)
Analytics › My Repeaters rows	390 / 1280	61–62.5 px	65–65.5 px	table sits in an overflow-x: auto wrapper, 864 → 868 px wide at 390

At 390 px #favToggle is not visible (it moves into More), so the dropdown was measured at 1280 only. The My Repeaters page overflows the viewport by 4 px (scrollWidth 394/1284) on master and merged alike. That is pre-existing and not caused by this PR.

1. "Already solved by #197/#201"

• Confirmed for 16 of the 17 files; the table above lists each one. test-packets.js is the one this PR registers. [T][A]
• The ported E2E files require plain playwright (const { chromium } = require('playwright')). @playwright/test and jsdom appear only in comments that explain the port. [T]
• KNOWN_UNREGISTERED in test-test-all.js on the merged tree has one entry: 'test-rx-coverage-mobile-nav-e2e.js': 'skips while clientRxCoverage is off (the default)'. The test-packets.js entry and the empty group comments are removed. [T]
• The merged test-all.sh runs 216 files, because master has added one since this PR's base 7697a826. The merge with master's test-all.sh change is clean. [T]

2. The registered unit file (test-packets.js)

• The fix is sound, not a "make it green" edit. The old assertion (#ph-caret-right) is kept as a knownBug that must fail, and knownBug fails the run once the bug is fixed. The plain test keeps two real checks: the collapsed group's expand cell holds a caret, and that caret is not the expanded one (caret-down). [A]
• The expand-cell regex /<td class="col-expand"[^>]*>…<\/td>/ matches the markup at packets.js:2377. [A]
• Mutants, run on a scratch copy of the merged tree [T]:
  • packets.js fixed (collapsed shows #ph-caret-right): exit 1, passes now, so known bug #189 is fixed: change knownBug() to test(). The flip alarm works.
  • collapsed shows #ph-caret-down: exit 1, collapsed group does not show the expanded caret.
  • collapsed has no caret: exit 1, collapsed group has a caret in its expand cell.
  • run test-packets.js removed from test-all.sh: node test-test-all.js fails with test-packets.js run nowhere.

3. .fav-star → 48 px

• Scoped. The diff changes only min-width/min-height: 44px to 48px and the comment in the existing .fav-star rule. It adds no colours, and the rule's existing colour already uses var(--text-muted), with .on using var(--status-yellow). The 22 px glyph is unchanged. [A]
• Layout. Nothing breaks at 390 px or at 1280 px. Rows that hold a star grow by 4 px in all three places (N2). No horizontal overflow is introduced, and table and dropdown widths stay within their containers. [T] I compared screenshots of /nodes at 390 px on master and merged: the same layout, with taller rows. The vertical offset between star and name exists on master too. [T]
• House rule. The decision fits: test-touch-targets.js (from fix(ui): 48px navigation and channel buttons (port of upstream 2078) #201) enforces DEFAULT_MIN = 48 for every listed button ("the shared 48px house minimum (style.css declares .nav-btn and .ch-icon-btn at both 48px and 44px Kpa-clawbot/CoreScope#2052)"), and adding .fav-star to that list is consistent with it. style.css declares .nav-btn and .ch-icon-btn at both 48px and 44px Kpa-clawbot/CoreScope#2052 itself was about channel row actions; see N1 for the controls outside the list. [A]
• Mutants [T]:
  • .fav-star back to 44 px: test-touch-targets.js fails with rendered 44.0x44.0 … expected >=48x48.
  • width alone at 44 px: fails with rendered 44.0x48.0.
  • the PR's test-issue-1648-m2-icons-e2e.js run against the master server (44 px CSS): (j) /nodes fav-star bbox 44x44 < 48x48, 20 passed, 1 failed.

4. Caret proposal

• packets.js is not touched (0 diff lines). [T]
• Collapsed #ph-caret-right with expanded #ph-caret-down restores the pre-Migrate emoji UI to Phosphor Icons (regular weight) — tracking Kpa-clawbot/CoreScope#1648 ▶/▼ pair. It matches #ptOverviewChevron in analytics.js (line 3981) and the collapsed route panel in route-view.js (line 523). Today packets.js shows up when collapsed and down when expanded, which fits neither the ▶/▼ convention nor nodes.js's "caret shows the action" convention (down = expand, up = collapse). The proposal is therefore an improvement, and the obvious choice for a table row disclosure. [A]
• Doing it after feat(packets): optional Hide CONTROL packets filter (#96) #211 is merged, and flipping knownBug() to test() then, is sensible. Mentioning the nodes.js convention in the follow-up would avoid a later "why not caret-down" debate (N3). [A]

5. Rules

• No npm dependency: package.json and package-lock.json are not in the diff. [T]
• The fork guard github.repository == 'Kpa-clawbot/CoreScope' appears 9 times in deploy.yml and 1 in release-fast-path.yml, at head and on the merged tree, and .github/ is not in the diff. [T]
• There are no closing keywords in the title, the body or the 3 commit messages ("Relates to test: 13 red orphan unit tests + 4 orphan E2E files left after #187; collapsed packet groups show an up-caret #189"). [T]
• All 3 commits (570a1195, da7e4538, 930234cc) have author and committer dborup <kontakt@meshview.dk>, with tests before the CSS. [T]
• The diff touches only relevant files: public/style.css, test-all.sh, test-test-all.js, test-packets.js, test-touch-targets.js and test-issue-1648-m2-icons-e2e.js. [T]

Tests

Run (merged tree)	Result
sh test-all.sh	216 passed, 0 failed (216 files), exit 0 [T]
node test-test-all.js	8 passed, 0 failed [T]
node test-frontend-helpers.js	707 passed, 0 failed [T]
The 11 #189 unit files, run one by one	all exit 0 [T]
CHROMIUM_REQUIRE=1 node test-touch-targets.js	OK [T]
test-issue-1648-m2-icons-e2e.js	21 passed, 0 failed [T]
test-nodes-favorite-rerender-e2e.js	4/4 [T]
test-issue-2052-touch-target-e2e.js	11/11 [T]
test-bottom-nav-1061-e2e.js	31/31 [T]
test-table-fluid-e2e.js	41/41 [T]
test-issue-1128-multi-viewport-e2e.js	15/15 [T]
The #189 E2E files (live-pulse-ring-weight, channel-modal, node-reach, path-inspector, 1522-trace-url-sync, rx-coverage-mobile-nav)	4/4, 15/15, OK, 6/6, 3/3, SKIP [T]

Mutants: seven in total, listed under §2 and §3, and all killed. [T]

CI per job (run 37204540498, head 930234c):

Job	Result
Go Build & Test	pass (22m57s) [T]
Playwright E2E Tests	pass (20m45s) [T]
Build & Publish Docker Image	pass (53s) [T]
Release Artifacts, Deploy Staging, Publish Badges & Summary	skipped (expected on a PR) [T]

Not verified

• The favourites dropdown at 390 px: #favToggle sits behind More there. A visual screenshot of the open dropdown is missing too, because my element screenshot came out clipped by the open animation. The dropdown is covered by measurements only.
• Other browsers and real touch devices; everything here ran in Chromium with emulated viewports.
• The full test-e2e-playwright.js run and the rest of the Playwright step. I ran the affected and test: 13 red orphan unit tests + 4 orphan E2E files left after #187; collapsed packet groups show an up-caret #189 files directly; the full step is covered by CI.
• The mutants from test: fix or retire the remaining orphan tests (#189) #197 and fix(ui): 48px navigation and channel buttons (port of upstream 2078) #201 were not re-run. [K]
• Staging and prod.

The head was 930234ccc50d36868bf79a2668e0018dcf45c095 before this review (git ls-remote) and still 930234ccc50d36868bf79a2668e0018dcf45c095 after it. The PR is still a draft and was not modified.