Skip to content

fix(frontend): handle orphaned api cleanup promise rejection #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborup merged 4 commits into from
Sep 15, 2026
Merged

fix(frontend): handle orphaned api cleanup promise rejection #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3c2483
fix(app.js): stop api()'s discarded finally-cleanup promise from doub…
Sep 14, 2026
8664575
test: fix two false-positive gaps found in independent review
Sep 14, 2026
98fbdbe
fix(test): close scenario H's false-pass and mislabelled child timeouts
Sep 14, 2026
3406159
test: register test-app-api-inflight-cleanup-rejection.js in CI lists
Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ jobs:
node test-packet-filter-time.js
node test-confidence-indicator.js
node test-1659-analytics-warmup.js
node test-app-api-inflight-cleanup-rejection.js
node test-channels-merge-1498-unit.js
node test-issue-1518-home-url.js
node test-channel-decrypt-insecure-context.js
Expand Down
8 changes: 7 additions & 1 deletion public/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,13 @@ async function api(path, { ttl = 0, bust = false } = {}) {
}
})();
_inflight.set(path, promise);
promise.finally(() => _inflight.delete(path));
// `.finally()` returns its own derived promise that mirrors `promise`'s
// outcome; discarding it uncaught leaves the real caller's rejection
// (delivered via the returned `promise` below, unaffected by this)
// duplicated as a second, unobserved rejection on this derived one.
// The `.catch()` here only silences that duplicate -- it does not
// touch `promise` itself or its resolution to callers.
promise.finally(() => _inflight.delete(path)).catch(() => {});
return promise;
}

Expand Down
1 change: 1 addition & 0 deletions test-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ node test-packet-filter-ux.js
node test-aging.js
node test-issue-1065-gesture-hints-gates.js
node test-frontend-helpers.js
node test-app-api-inflight-cleanup-rejection.js
node test-privacy-page.js
node test-nav-dynamic-link-lifecycle.js
node test-nav-first-load-fit.js
Expand Down
Loading
Loading