CI integration only: #28 + #50 — do not merge by adminopenclaw8-sketch · Pull Request #66 · dborup/CoreScope

adminopenclaw8-sketch · 2026-09-18T09:18:53Z

Update 2026-09-19: re-integrated on master after #67 (still CI-only, do not merge)

	Previous	Now
master	`37d82e8a`	`31c2aa8e3869822f79a8414d89277d5552669056` (includes #67)
#28 head	`6e40de4c`	`e55810a78f9ea32e29b1b08698c5e5c57b33fe9c`
#50 head	`a0d3fdd9`	`adafd563051a6f8fb34f5e1c115b82b7ee2a167e`
integration head	`7368310e`	`2f6352e96a71ce328c009d694ec3ee191608cf05`

Fast-forward update of this branch (no force-push): 6151fb29 merges the new port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28 head, 2f6352e9 merges the new port(upstream#2007): 23 more names in the channel rainbow list #50 head (ordinary merges, in that order).
Tree fa19d841428f8f3e7c01ab8fc293ccb72e7eb029 equals the read-only precomputed master + port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28 + port(upstream#2007): 23 more names in the channel rainbow list #50 result. Diff vs master is exactly public/rx-coverage.js, channel-rainbow.json, internal/channel/channel_rainbow_test.go. fix(packets): keep the Details summary on one line so rows stay bounded #67's three files and all workflows are byte-identical to master; 9 fork guards unchanged.
Local (integration tree): JS syntax PASS; workflow YAML parses; fork-guard Go tests (TestForkGuardOnSideEffectJobs, TestForkGuardOnPublishSteps, TestForkGuardLeavesTestJobsRunning) PASS; internal/channel PASS; test-rx-coverage-config-race.js PASS (test-rx-coverage-mobile-nav-e2e.js SKIP: RX coverage disabled in the fixture config).
Row-height tests on the integrated tree (local fixture server, Chromium 1208): test-issue-1122-packets-filter-ux-e2e.js 6/6 (incl. "Path column row height stays bounded < 60px"), test-issue-1122-details-row-clamp-e2e.js 18/18.
CI: run 35424494579 on 2f6352e9: success. Go Build & Test and Playwright E2E success; #1122 "Path column row height < 60px" PASS; clamp test 18/18. Docker job success with GHCR steps skipped. Release, Deploy Staging, Badges skipped (fork guards).
This PR is a draft integration check only and must not be merged. port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28 and port(upstream#2007): 23 more names in the channel rainbow list #50 are merged individually.
The row-height blocker that failed this PR's previous CI run is resolved on master by fix(packets): keep the Details summary on one line so rows stay bounded #67. The section below describes the previous integration and is kept for history.

CI-only integration check. Not intended for merge. This PR verifies that #28 and #50 combine cleanly with each other and with current master; it does not merge either PR and is not itself meant to be merged.

Heads

Branch	Head	Base
`codex/port-upstream-1860-rx-coverage-icon` (#28)	`6e40de4c7184756984910c8cfc54b49125ae3d33`	`37d82e8a1844234e498c0c909d0fb1155ea858d7`
`codex/port-upstream-2007-rainbow-channel-names` (#50)	`a0d3fdd9b29b30d6be91eda27eff8303d7fc746a`	`37d82e8a1844234e498c0c909d0fb1155ea858d7`
master (verified before integration)	`37d82e8a1844234e498c0c909d0fb1155ea858d7`	—

Both PR heads already carried an ordinary merge commit against this exact master (#28's earlier update, #50's earlier update) — this branch does not rebase or amend either.

Merge order and commits

0f9416daee09c1f71ed0505c96f733bc43b0d902 — merge port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28's head into master (ordinary merge, --no-ff)
7368310ef666371d8f49c9229053b7058072d946 — merge port(upstream#2007): 23 more names in the channel rainbow list #50's head on top (ordinary merge, --no-ff) — integration head

Tree: 6ee0c441c45e7e88b8a9b4f9f73610edf792bdac.

Verified

No conflicts in either merge step.
Combined diff vs master is exactly the expected 3 files: public/rx-coverage.js (+1/-1), channel-rainbow.json (+24/-1), internal/channel/channel_rainbow_test.go (new, +97) — nothing else.
Per-file content is byte-identical to each PR's own approved diff vs master (checked individually) — the two PRs don't interact; port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28 and port(upstream#2007): 23 more names in the channel rainbow list #50 touch disjoint files.
fix(nodes): separate advert timestamps from confirmed relay activity #64 (cmd/server/node_activity.go) and port(upstream#2003): join the watchdog loop goroutine in tests #48 (both watchdog Stop-tests) confirmed present.
.github/workflows/deploy.yml and release-fast-path.yml are byte-identical blob SHAs to master (not just diff-empty) — fork-guards (github.repository == 'Kpa-clawbot/CoreScope', 9 occurrences, same count as master) intact and unmodified.
git diff --check clean.

Local verification (proportional, not a full re-audit)

node --check public/rx-coverage.js: PASS
node test-rx-coverage-config-race.js: PASS
channel-rainbow.json: valid JSON, 320 entries
internal/channel: TestChannelRainbowMatchesDeriveKey PASS, full package PASS
Live browser check of #/rx-coverage, desktop and mobile (375×812), clientRxCoverage enabled only in a local, throwaway test config (/tmp, never committed): ph-map-trifold SVG icon renders correctly at both sizes, no emoji — same result as port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28's own verification, unaffected by port(upstream#2007): 23 more names in the channel rainbow list #50's presence
node test-rx-coverage-escape.js: fails, same already-documented pre-existing harness defect (stale string marker; see port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28's own PR description) — reported here for completeness, not fixed or worked around in this branch
The bug(packets): filter UX disaster — help panel overlaps table, toolbar chaotic, path chips spill rows Kpa-clawbot/CoreScope#1122/fix(packets): filter UX disaster — modal help, single header, bounded path rows (#1122) Kpa-clawbot/CoreScope#1124 row-height question was not re-run here (already resolved with a CI-faithful reproduction in port(upstream#2007): 23 more names in the channel rainbow list #50 directly, and confirmed passing in real CI on a0d3fdd9); re-running it would not add information proportional to this check's scope

No code was changed to make anything pass.

Limitations

This is a synthetic integration point that has not itself gone through independent review.
CI here validates the combination; it is still each PR's own CI (already green individually) that is the primary signal.
No staging, deploy, or production verification was performed or is implied by this PR being open.

🤖 Generated with Claude Code

… rx-coverage (Kpa-clawbot#1860) ## Summary `public/rx-coverage.js` still carried a literal `🗺️` (U+1F5FA) in the Mobile RX coverage page header — missed by the Kpa-clawbot#1648 emoji → Phosphor migration. Replaced with `ph-map-trifold` from the existing sprite, matching how every other page header renders (`analytics.js`, `home.js`, `node-analytics.js`, `customize-v2.js`). ```diff -'<h2 style="margin:4px 0 2px;font-size:18px">🗺️ Mobile RX coverage</h2>' + +'<h2 style="margin:4px 0 2px;font-size:18px"><svg class="ph-icon" aria-hidden="true"><use href="/icons/phosphor-sprite.svg#ph-map-trifold"/></svg> Mobile RX coverage</h2>' + ``` ## How it got through This is not a gap in the tooling — `test-issue-1648-m6-final-sweep.js` catches it correctly. On current `master` (`a06ac8ac`): ``` ✗ 1 emoji-as-icon violation(s): public/rx-coverage.js:29 [U+1F5FA] '<h2 style="margin:4px 0 2px;font-size:18px">🗺️ Mobile RX coverage</h2>' + ``` The gate is in `test-all.sh` but not in the CI test list in `deploy.yml`, so it never runs. That divergence is filed separately as Kpa-clawbot#1858 — this PR is the concrete defect it let through. ## Test plan - [x] `node test-issue-1648-m6-final-sweep.js` — `✓ lint gate: 0 violations across public/** and cmd/**` (was 1 violation before) - [x] `node test-issue-1648-m6-lint-self.js` — green, including the anti-tautology probe (it requires a clean repo to run at all, so it was failing on master purely as a cascade from the above) - [x] `eslint public/rx-coverage.js` — 0 errors (1 pre-existing `no-unused-vars` warning on `selectedName`, untouched) - [x] `ph-map-trifold` confirmed present in `public/icons/phosphor-sprite.svg` Single-line change, no behaviour change beyond the icon glyph. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: SaarMesh-Bot <300107934+SaarMesh-Bot@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit a3454e7) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Verified: every value is SHA-256(name)[:16] per internal/channel.DeriveKey, 319/320 exact (Public is the fixed firmware default), no duplicate hashes, file parses at 320 entries. (cherry picked from commit c283f42) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

… rx-coverage (Kpa-clawbot#1860) ## Summary `public/rx-coverage.js` still carried a literal `🗺️` (U+1F5FA) in the Mobile RX coverage page header — missed by the Kpa-clawbot#1648 emoji → Phosphor migration. Replaced with `ph-map-trifold` from the existing sprite, matching how every other page header renders (`analytics.js`, `home.js`, `node-analytics.js`, `customize-v2.js`). ```diff -'<h2 style="margin:4px 0 2px;font-size:18px">🗺️ Mobile RX coverage</h2>' + +'<h2 style="margin:4px 0 2px;font-size:18px"><svg class="ph-icon" aria-hidden="true"><use href="/icons/phosphor-sprite.svg#ph-map-trifold"/></svg> Mobile RX coverage</h2>' + ``` ## How it got through This is not a gap in the tooling — `test-issue-1648-m6-final-sweep.js` catches it correctly. On current `master` (`a06ac8ac`): ``` ✗ 1 emoji-as-icon violation(s): public/rx-coverage.js:29 [U+1F5FA] '<h2 style="margin:4px 0 2px;font-size:18px">🗺️ Mobile RX coverage</h2>' + ``` The gate is in `test-all.sh` but not in the CI test list in `deploy.yml`, so it never runs. That divergence is filed separately as Kpa-clawbot#1858 — this PR is the concrete defect it let through. ## Test plan - [x] `node test-issue-1648-m6-final-sweep.js` — `✓ lint gate: 0 violations across public/** and cmd/**` (was 1 violation before) - [x] `node test-issue-1648-m6-lint-self.js` — green, including the anti-tautology probe (it requires a clean repo to run at all, so it was failing on master purely as a cascade from the above) - [x] `eslint public/rx-coverage.js` — 0 errors (1 pre-existing `no-unused-vars` warning on `selectedName`, untouched) - [x] `ph-map-trifold` confirmed present in `public/icons/phosphor-sprite.svg` Single-line change, no behaviour change beyond the icon glyph. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: SaarMesh-Bot <300107934+SaarMesh-Bot@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit a3454e7) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Verified: every value is SHA-256(name)[:16] per internal/channel.DeriveKey, 319/320 exact (Public is the fixed firmware default), no duplicate hashes, file parses at 320 entries. (cherry picked from commit c283f42) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Brings in: - #64: fix(nodes): separate advert timestamps from confirmed relay activity - #48: test(ingestor): reconcile watchdog Stop-test coverage (StopJoinsLoop + StopIsIdempotent), fixing the CI watchdog flake this PR previously hit No conflicts. PR #28's own change (public/rx-coverage.js) is untouched by this merge.

Brings in: - #64: fix(nodes): separate advert timestamps from confirmed relay activity - #48: test(ingestor): reconcile watchdog Stop-test coverage (StopJoinsLoop + StopIsIdempotent) No conflicts. PR #50's own change (channel-rainbow.json, internal/channel/channel_rainbow_test.go) is untouched by this merge. Does not address the row-height test Kpa-clawbot#1122/Kpa-clawbot#1124 failure — that is investigated separately, unresolved.

Head: 6e40de4 Base: 37d82e8 Read-only integration test only. Not intended for merge to master.

… branch Head: a0d3fdd Base: 0f9416d (integration branch after PR #28) Read-only integration test only. Not intended for merge to master.

…ion branch

dborup · 2026-09-19T10:10:56Z

Superseded: both integrated PRs are now on master, so this CI-only integration check is no longer needed.

port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28 merged as 20ab52232047735e83989a3a547700f00f9366c7 (parents 31c2aa8e + e55810a7)
port(upstream#2007): 23 more names in the channel rainbow list #50 merged as 8b9b9d60c52e99ac5b54c3e938420c6594fe9afe (parents 20ab5223 + adafd563)
New master: 8b9b9d60c52e99ac5b54c3e938420c6594fe9afe, tree fa19d841428f8f3e7c01ab8fc293ccb72e7eb029, which is byte-identical to this branch's tested head 2f6352e9 (empty diff).

Closing without merging. The branch is kept.

SaarMesh-Bot and others added 12 commits September 13, 2026 10:42

Integrate prep PR28 with master

c467090

Integrate prep PR50 with master

ff481eb

Update PR28 onto master

c178df5

Update PR50 onto master

bdde3e3

Merge PR #28 (RX coverage icon) into CI-only integration branch

0f9416d

Head: 6e40de4 Base: 37d82e8 Read-only integration test only. Not intended for merge to master.

Merge PR #50 (23 more rainbow channel names) into CI-only integration…

7368310

… branch Head: a0d3fdd Base: 0f9416d (integration branch after PR #28) Read-only integration test only. Not intended for merge to master.

This was referenced Sep 18, 2026

fix(packets): keep the Details summary on one line so rows stay bounded #67

Merged

feat(reach): Reach leaderboard with a shared visible-population rank #69

Merged

dborup added 4 commits September 19, 2026 07:35

Merge origin/master (post #67) into PR #28

e55810a

Merge origin/master (post #67) into PR #50

adafd56

Merge updated PR #28 (e55810a, post #67 master) into CI-only integrat…

6151fb2

…ion branch

Merge updated PR #50 (adafd56, post #67 master) into CI-only integrat…

2f6352e

…ion branch

This was referenced Sep 19, 2026

port(upstream#1860): Phosphor icon instead of emoji in the RX coverage header #28

Merged

port(upstream#2007): 23 more names in the channel rainbow list #50

Merged

dborup closed this Sep 19, 2026

Navigation Menu

CI integration only: #28 + #50 — do not merge - #66

CI integration only: #28 + #50 — do not merge#66
adminopenclaw8-sketch wants to merge 16 commits into
masterfrom
codex/ci-integration-pr28-pr50-37d82e8a

adminopenclaw8-sketch commented Sep 18, 2026 •

edited by dborup

Loading

Uh oh!

dborup commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adminopenclaw8-sketch commented Sep 18, 2026 • edited by dborup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update 2026-09-19: re-integrated on master after #67 (still CI-only, do not merge)

Heads

Merge order and commits

Verified

Local verification (proportional, not a full re-audit)

Limitations

Uh oh!

dborup commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adminopenclaw8-sketch commented Sep 18, 2026 •

edited by dborup

Loading